build: add working lint-ci make target (v0.12) - #9151
Closed
rvagg wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
PR-URL: nodejs#9107 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Copy link
Copy Markdown
Member
Author
|
CI @ https://ci.nodejs.org/job/node-test-pull-request/4553/ with a happy linter! fwiw I also cherry-picked over #9107 to v0.12-staging to fix a linting problem that's common with v0.10. |
Sorry, something went wrong.
bnoordhuis
approved these changes
Oct 18, 2016
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
JungMinu
approved these changes
Oct 19, 2016
jbergstroem
approved these changes
Oct 19, 2016
jbergstroem
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Comment thread
Makefile
|
|
||
| CONFLICT_RE=^>>>>>>> [0-9A-Fa-f]+|^<<<<<<< [A-Za-z]+ | ||
| lint-ci: jslint cpplint | ||
| @if ! ( grep -IEqrs "$(CONFLICT_RE)" benchmark deps doc lib src test tools ) \ |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
The SmartOS man-page didn't show all flags passed to grep being available, but it seems to work fine anyway.
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Oct 28, 2016
PR-URL: #9151 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com>
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Dec 22, 2016
PR-URL: nodejs/node#9151 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make linting work again on v0.12! We've been missing this since we switched to lint-ci on Jenkins but nobody noticed (cause I'm pretty much the only one who runs it and I'd forgotten that it was only v0.10 that should fail linting).
/cc @nodejs/build