FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix header level for crypto.constants by evanlucas · Pull Request #9187 · nodejs/node · GitHub

/ node Public

doc: fix header level for crypto.constants - #9187

Closed
evanlucas wants to merge 1 commit into
nodejs:masterfrom
evanlucas:cryptodocheader
Closed

doc: fix header level for crypto.constants#9187
evanlucas wants to merge 1 commit into
nodejs:masterfrom
evanlucas:cryptodocheader

Conversation

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

The header level for crypto.constants was off by one.

The header level for crypto.constants was off by one.

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mscdex added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Oct 19, 2016

jasnell commented Oct 19, 2016

Copy link
Copy Markdown
Member

LGTM. trivial enough to not wait the full 48 hours.

jasnell self-assigned this Oct 19, 2016
jasnell pushed a commit that referenced this pull request Oct 19, 2016
The header level for crypto.constants was off by one.

PR-URL: #9187
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Oct 19, 2016

Copy link
Copy Markdown
Member

Landed in ca3c8a9.

jasnell closed this Oct 19, 2016
evanlucas deleted the cryptodocheader branch October 19, 2016 17:24
jasnell pushed a commit that referenced this pull request Oct 20, 2016
The header level for crypto.constants was off by one.

PR-URL: #9187
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 11, 2016
The header level for crypto.constants was off by one.

PR-URL: #9187
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Nov 22, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL