test: fix flaky test by removing timer - #9199
Merged
evanlucas merged 1 commit intoOct 25, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
cjihrig
approved these changes
Oct 20, 2016
Copy link
Copy Markdown
Member
|
LGTM, #9197 is basically the same fix, doesn't matter much which one lands, but one of them should. :-D |
Sorry, something went wrong.
santigimeno
approved these changes
Oct 20, 2016
Copy link
Copy Markdown
Contributor
Author
|
@Trott I'm pretty sure they both need to land. Those are two different files (although pretty similar). |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@evanlucas Needless to say (but I'm going to say it anyway), you are correct! |
Sorry, something went wrong.
Trott
reviewed
Oct 20, 2016
Comment thread
test/parallel/test-dgram-send-callback-buffer.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nit: While we're in here anyway, maybe change this to assert.strictEqual()?
Sorry, something went wrong.
Trott
reviewed
Oct 20, 2016
Comment thread
test/parallel/test-dgram-send-callback-buffer.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nit: assert.ifError()?
Sorry, something went wrong.
lpinca
approved these changes
Oct 20, 2016
This fixes one of the tests that has been failing on CI on freebsd for a bit by removing an unnecessary timer. PR-URL: nodejs#9199 Fixes: nodejs#7929 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
evanlucas
added a commit
that referenced
this pull request
Nov 2, 2016
This fixes one of the tests that has been failing on CI on freebsd for a bit by removing an unnecessary timer. PR-URL: #9199 Fixes: #7929 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 18, 2016
This fixes one of the tests that has been failing on CI on freebsd for a bit by removing an unnecessary timer. PR-URL: #9199 Fixes: #7929 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 19, 2016
This fixes one of the tests that has been failing on CI on freebsd for a bit by removing an unnecessary timer. PR-URL: #9199 Fixes: #7929 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
This fixes one of the tests that has been failing on CI on freebsd for
a bit by removing an unnecessary timer.
Fixes: #7929