| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Disable stdio buffering, it interacts poorly with printf() calls from elsewhere in the program (e.g., any logging from V8.) Unbreaks among other things the `--trace_debug_json` switch. Undoes commit 0966ab9 ("src: force line buffering for stderr"), which in retrospect is not a proper fix. Turning on line buffering fixed a flaky test on SmartOS but the test wasn't failing on other platforms, where stderr wasn't line-buffered either. Mark the test flaky again, it failed once in a run of 333 tries on the smartos-64 buildbot. Disabling buffering should be safe even when mixed with non-blocking stdio I/O because libuv goes to great lengths to reopen the tty file descriptors and falls back to blocking I/O when that fails. PR-URL: nodejs#7610 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
There was a problem hiding this comment.
LGTM if CI and CITGM are green
Sorry, something went wrong.
There was a problem hiding this comment.
Same as what @jasnell told
Sorry, something went wrong.
Sorry, something went wrong.
|
one more BSD run https://ci.nodejs.org/job/node-test-commit-freebsd/4976/ |
Sorry, something went wrong.
|
BSD 10 is good, BSD 11 is known to be bad |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Cherry-pick of #7610 to v4.x-staging.
R=@thealphanerd