tools: enable ES2016 support in ESLint - #9218
Conversation
Sorry, something went wrong.
not-an-aardvark
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
thefourtheye
left a comment
There was a problem hiding this comment.
Should we consider performance implications of the new features before allowing us to use this?
Sorry, something went wrong.
|
@thefourtheye you're right. Though I would be surprised if V8 didn't just convert this operator to a Math.pow call. |
Sorry, something went wrong.
|
@targos Looks like, in ** case, it is internally translated to Math.pow call only, if I am not wrong. https://codereview.chromium.org/1678303002/diff/320001/src/parsing/parser.cc?context=10&column_width=80&tab_spaces=8 |
Sorry, something went wrong.
|
Linter CI run: https://ci.nodejs.org/job/node-test-linter/4942/ |
Sorry, something went wrong.
|
@targos What about the other features in es2016? Do we have any rough idea if they will also be performing at par with their es2015 equivalents? Because once we allow them in the linter it means that we officially allow es2016 in our codebase. |
Sorry, something went wrong.
|
The exponentiation operator is the only new syntax of ES2016. This change doesn't add support for other features. |
Sorry, something went wrong.
There was a problem hiding this comment.
Nit: what about adding a blank line before this one?
Sorry, something went wrong.
There was a problem hiding this comment.
Ack. I'll do it on merge
Sorry, something went wrong.
|
Maybe I can change the commit message to tools: enable ES2016 syntax support in ESLint to make it clearer. |
Sorry, something went wrong.
This allows us to use the exponentiation operator. PR-URL: nodejs#9218 Ref: nodejs#9208 (comment) Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This allows us to use the exponentiation operator. PR-URL: #9218 Ref: #9208 (comment) Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This allows us to use the exponentiation operator. PR-URL: #9218 Ref: #9208 (comment) Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This allows us to use the exponentiation operator. PR-URL: #9218 Ref: #9208 (comment) Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Checklist
Affected core subsystem(s)
tools
Description of change
This allows to use the exponentiation operator.
Ref: #9208 (comment)