FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: clean up `test-child-process-exec-cwd.js` by jeenalee · Pull Request #9231 · nodejs/node · GitHub

/ node Public

test: clean up test-child-process-exec-cwd.js - #9231

Closed
jeenalee wants to merge 1 commit into
nodejs:masterfrom
jeenalee:test-refactor
ConversationCommits (1)ChecksFiles changed
Closed

test: clean up test-child-process-exec-cwd.js#9231
jeenalee wants to merge 1 commit into
nodejs:masterfrom
jeenalee:test-refactor

Conversation

jeenalee commented Oct 21, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

This patch provides minor fixes to test-child-process-exec-cwd.js. Notably:

  • Changed == to ===.
  • Changed var to const where possible.

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 21, 2016

jeenalee commented Oct 21, 2016

Copy link
Copy Markdown
Contributor Author

cc @Trott

mscdex added the child_process Issues and PRs related to the child_process subsystem. label Oct 21, 2016
cjihrig reviewed Oct 21, 2016
View reviewed changes
Comment thread test/parallel/test-child-process-exec-cwd.js Outdated

cjihrig Oct 21, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This would probably make more sense as assert.strictEqual(stdout.indexOf(dir), 0);

cjihrig approved these changes Oct 21, 2016
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with a suggestion.

Trott approved these changes Oct 21, 2016
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. I like @cjihrig's suggestion.

Trott commented Oct 21, 2016

Copy link
Copy Markdown
Member

Nit: Clean-up in commit message to clean up. (Whoever lands the change can fix that up, but if you want to save them some keystrokes, go for it.)

jeenalee commented Oct 22, 2016

Copy link
Copy Markdown
Contributor Author

Review comments, including editing commit message, addressed. Thanks everyone!

test: clean up test-child-process-exec-cwd.js
381a524 
- Changed `assert.ok()` to `assert.strictEqual()`.
- Changed `var` to `const` where possible.
jeenalee changed the title test: Clean-up test-child-process-exec-cwd.js test: clean up test-child-process-exec-cwd.js Oct 22, 2016

Trott commented Oct 22, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/4617/

imyller approved these changes Oct 24, 2016
View reviewed changes

imyller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jasnell commented Oct 25, 2016

Copy link
Copy Markdown
Member

too much red in that last CI run.. trying again: https://ci.nodejs.org/job/node-test-pull-request/4667/

Trott pushed a commit to Trott/io.js that referenced this pull request Oct 26, 2016
test: clean up test-child-process-exec-cwd.js
2d472a3 
- Changed `assert.ok()` to `assert.strictEqual()`.
- Changed `var` to `const` where possible.

PR-URL: nodejs#9231
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>

Trott commented Oct 26, 2016

Copy link
Copy Markdown
Member

Landed in 2d472a3

Trott closed this Oct 26, 2016
evanlucas pushed a commit that referenced this pull request Nov 2, 2016
test: clean up test-child-process-exec-cwd.js
53520f0 
- Changed `assert.ok()` to `assert.strictEqual()`.
- Changed `var` to `const` where possible.

PR-URL: #9231
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
evanlucas mentioned this pull request Nov 3, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
test: clean up test-child-process-exec-cwd.js
1e0a8d7 
- Changed `assert.ok()` to `assert.strictEqual()`.
- Changed `var` to `const` where possible.

PR-URL: #9231
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
MylesBorins pushed a commit that referenced this pull request Nov 19, 2016
test: clean up test-child-process-exec-cwd.js
5d4f757 
- Changed `assert.ok()` to `assert.strictEqual()`.
- Changed `var` to `const` where possible.

PR-URL: #9231
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
test: clean up test-child-process-exec-cwd.js
8d985c2 
- Changed `assert.ok()` to `assert.strictEqual()`.
- Changed `var` to `const` where possible.

PR-URL: #9231
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
MylesBorins mentioned this pull request Nov 22, 2016
Merged
snyk-bot mentioned this pull request Jan 11, 2023
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
imyller imyller approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL