FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: use wxneeded on openbsd by qbit · Pull Request #9232 · nodejs/node · GitHub

/ node Public

build: use wxneeded on openbsd - #9232

Closed
qbit wants to merge 2 commits into
nodejs:masterfrom
qbit:master
ConversationCommits (2)ChecksFiles changed
Closed

build: use wxneeded on openbsd#9232
qbit wants to merge 2 commits into
nodejs:masterfrom
qbit:master

Conversation

qbit commented Oct 21, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Description of change

On OpenBSD 6.0 and greater W^X is enabled by default. All executables
that violate W^X need to be marked with PT_OPENBSD_WXNEEDED. In
addition to this, they must be executed from a filesystem mounted with
'wxallowed'.

More info on W^X: https://en.wikipedia.org/wiki/W%5EX

build: use wxneeded on openbsd
60eb674 
On OpenBSD 6.0 and greater W^X is enabled by default. All executables
that violate W^X need to be marked with PT_OPENBSD_WXNEEDED. In
addition to this, they must be executed from a filesystem mounted with
'wxallowed'.

More info on W^X: https://en.wikipedia.org/wiki/W%5EX
nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Oct 21, 2016

qbit commented Oct 22, 2016

Copy link
Copy Markdown
Contributor Author

@bnoordhuis @jasnell would it be possible to get this: c-ares/c-ares#68 back ported to the cares dep?

bnoordhuis commented Oct 23, 2016

Copy link
Copy Markdown
Member

If it landed upstream I'm fine with that. Do you want to add it to this pull request or do you want to file a new one?

jbergstroem approved these changes Oct 23, 2016
View reviewed changes

jbergstroem left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

qbit commented Oct 23, 2016

Copy link
Copy Markdown
Contributor Author

Added the c-ares fix.

bnoordhuis approved these changes Oct 25, 2016
View reviewed changes

bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. CI: https://ci.nodejs.org/job/node-test-pull-request/4668/

jasnell commented Oct 26, 2016

Copy link
Copy Markdown
Member

New CI because previous was partially canceled: https://ci.nodejs.org/job/node-test-pull-request/4691/

jasnell commented Oct 28, 2016

Copy link
Copy Markdown
Member

Unrelated failure in CI. Will land this.

jasnell self-assigned this Oct 28, 2016
jasnell pushed a commit that referenced this pull request Oct 28, 2016
build: use wxneeded on openbsd
a0c6898 
On OpenBSD 6.0 and greater W^X is enabled by default. All executables
that violate W^X need to be marked with PT_OPENBSD_WXNEEDED. In
addition to this, they must be executed from a filesystem mounted with
'wxallowed'.

More info on W^X: https://en.wikipedia.org/wiki/W%5EX

PR-URL: #9232
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
jasnell pushed a commit that referenced this pull request Oct 28, 2016
deps: back port OpenBSD fix in c-ares/c-ares
40fd696 
Original PR: c-ares/c-ares#68

PR-URL: #9232
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

jasnell commented Oct 28, 2016

Copy link
Copy Markdown
Member

Landed in a0c6898...40fd696

jasnell closed this Oct 28, 2016
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
build: use wxneeded on openbsd
f7d8481 
On OpenBSD 6.0 and greater W^X is enabled by default. All executables
that violate W^X need to be marked with PT_OPENBSD_WXNEEDED. In
addition to this, they must be executed from a filesystem mounted with
'wxallowed'.

More info on W^X: https://en.wikipedia.org/wiki/W%5EX

PR-URL: #9232
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
deps: back port OpenBSD fix in c-ares/c-ares
0f871e1 
Original PR: c-ares/c-ares#68

PR-URL: #9232
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
evanlucas mentioned this pull request Nov 3, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
deps: back port OpenBSD fix in c-ares/c-ares
91fce10 
Original PR: c-ares/c-ares#68

PR-URL: #9232
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
deps: back port OpenBSD fix in c-ares/c-ares
8d2bc95 
Original PR: c-ares/c-ares#68

PR-URL: #9232
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins commented Nov 18, 2016

Copy link
Copy Markdown
Contributor

landed on v4 and v6. Please let me know if there are any issues

MylesBorins pushed a commit that referenced this pull request Nov 19, 2016
deps: back port OpenBSD fix in c-ares/c-ares
f0a8bcc 
Original PR: c-ares/c-ares#68

PR-URL: #9232
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
build: use wxneeded on openbsd
59d821d 
On OpenBSD 6.0 and greater W^X is enabled by default. All executables
that violate W^X need to be marked with PT_OPENBSD_WXNEEDED. In
addition to this, they must be executed from a filesystem mounted with
'wxallowed'.

More info on W^X: https://en.wikipedia.org/wiki/W%5EX

PR-URL: #9232
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
build: use wxneeded on openbsd
c857586 
On OpenBSD 6.0 and greater W^X is enabled by default. All executables
that violate W^X need to be marked with PT_OPENBSD_WXNEEDED. In
addition to this, they must be executed from a filesystem mounted with
'wxallowed'.

More info on W^X: https://en.wikipedia.org/wiki/W%5EX

PR-URL: #9232
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This was referenced Nov 22, 2016
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
jasnell jasnell approved these changes
+1 more reviewer
jbergstroem jbergstroem approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jasnell

Labels

build Issues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL