src: fix use of uninitialized variable - #9281
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
bnoordhuis
approved these changes
Oct 28, 2016
bnoordhuis
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with nit. Does valgrind -q complain without this patch? If no, consider adding a regression test.
Sorry, something went wrong.
Comment thread
src/node_i18n.cc
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
You have an extraneous paren in the string.
Sorry, something went wrong.
Variable was uninitialized in 72547fe Initialize the variable and add a static_check
jasnell
force-pushed
the
check-uninitialized
branch
from
f8dfec9 to
e0bad1e
Compare
October 28, 2016 19:13
Copy link
Copy Markdown
Contributor
|
This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
src
Description of change
Alternative to #9280 ...
The proposed fix in 9280 breaks the calculation algorithm.
Variable was uninitialized in 72547fe Initialize the variable and add a static_check
/cc @bnoordhuis @addaleax