test: favor === over == in fs-utimes - #9290
Closed
jun-oka wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
This is a good start, but there are other improvements that can be made while you're updating this test:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@cjihrig Sorry, I overlooked var and const one before I commit. Thank you for common.mustCall() and common.fail() info! I will handle it today. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I'd also add that if you do end up keeping the assert.equal(), it would be great if it were possible to use assert.strictEqual() instead. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@Trott Understood. I found it on Line 143. Thank you. |
Sorry, something went wrong.
jun-oka
force-pushed
the
test-fs-utimes-eqeqeq
branch
from
9c93f6c to
8133444
Compare
December 24, 2016 18:08
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
targos
approved these changes
Dec 24, 2016
jasnell
approved these changes
Dec 24, 2016
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Trott
force-pushed
the
test-fs-utimes-eqeqeq
branch
from
8133444 to
90b88b9
Compare
January 7, 2017 00:02
Copy link
Copy Markdown
Member
|
Landed in 377ea28. |
Sorry, something went wrong.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jan 7, 2017
* favor `===` over `==` * `var` -> `const`/`let` * use `common.mustCall()` PR-URL: nodejs#9290 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
* favor `===` over `==` * `var` -> `const`/`let` * use `common.mustCall()` PR-URL: nodejs#9290 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 19, 2017
* favor `===` over `==` * `var` -> `const`/`let` * use `common.mustCall()` PR-URL: nodejs#9290 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 25, 2017
* favor `===` over `==` * `var` -> `const`/`let` * use `common.mustCall()` PR-URL: nodejs#9290 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
* favor `===` over `==` * `var` -> `const`/`let` * use `common.mustCall()` PR-URL: nodejs#9290 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 8, 2017
* favor `===` over `==` * `var` -> `const`/`let` * use `common.mustCall()` PR-URL: #9290 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 8, 2017
* favor `===` over `==` * `var` -> `const`/`let` * use `common.mustCall()` PR-URL: #9290 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
* favor `===` over `==` * `var` -> `const`/`let` * use `common.mustCall()` PR-URL: #9290 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
* favor `===` over `==` * `var` -> `const`/`let` * use `common.mustCall()` PR-URL: #9290 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test fs-utimes