FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: run all of test-timers-blocking-callback by Trott · Pull Request #9305 · nodejs/node · GitHub

/ node Public

test: run all of test-timers-blocking-callback - #9305

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:two-tests
ConversationCommits (1)ChecksFiles changed
Closed

test: run all of test-timers-blocking-callback#9305
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:two-tests

Conversation

Trott commented Oct 26, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test timers

Description of change

The test has two test cases, but only the first was being run due to a
small bug. This change fixes the bug.

/cc @misterdjules

Refs: #8041

test: run all of test-timers-blocking-callback
0644b62 
The test has two test cases, but only the first was being run due to a
small bug. This change fixes the bug.
Trott added timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. test Issues and PRs related to the tests. labels Oct 26, 2016
nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 26, 2016
misterdjules approved these changes Oct 27, 2016
View reviewed changes

misterdjules left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good catch, and my apologies again. This test is definitely not written in a way that makes it easy to reason about it.

These changes look good to me. Eventually it would be good to also assert on the number of blockingCallback calls, but that can be done in a separate PR. This is already a significant improvement.

jasnell reviewed Oct 28, 2016
View reviewed changes
Comment thread test/parallel/test-timers-blocking-callback.js

timeCallbackScheduled = Timer.now();
setTimeout(blockingCallback, TIMEOUT);
setTimeout(blockingCallback.bind(null, callback), TIMEOUT);

jasnell Oct 28, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

setTimeout(() => blockingCallback(callback), TIMEOUT); ?

Trott Oct 28, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I did it this way to match what was already on line 67 so that it was clear that they were doing the same thing.

Trott commented Oct 28, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/4725/

Trott added a commit to Trott/io.js that referenced this pull request Oct 29, 2016
test: run all of test-timers-blocking-callback
2c6ca32 
The test has two test cases, but only the first was being run due to a
small bug. This change fixes the bug.

PR-URL: nodejs#9305
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Trott commented Oct 29, 2016

Copy link
Copy Markdown
Member Author

Landed in 2c6ca32

Trott closed this Oct 29, 2016
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
test: run all of test-timers-blocking-callback
bd9cb40 
The test has two test cases, but only the first was being run due to a
small bug. This change fixes the bug.

PR-URL: #9305
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas mentioned this pull request Nov 3, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
test: run all of test-timers-blocking-callback
4fcc2c1 
The test has two test cases, but only the first was being run due to a
small bug. This change fixes the bug.

PR-URL: #9305
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Nov 22, 2016
Merged
Trott deleted the two-tests branch January 13, 2022 22:44
snyk-bot mentioned this pull request Jan 11, 2023
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell left review comments
cjihrig cjihrig approved these changes
+1 more reviewer
misterdjules misterdjules approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL