FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Updated reference to signal list in "signal events" section by emadb · Pull Request #9323 · nodejs/node · GitHub

/ node Public

Updated reference to signal list in "signal events" section - #9323

Closed
emadb wants to merge 3 commits into
nodejs:masterfrom
emadb:patch-1
ConversationCommits (3)ChecksFiles changed
Closed

Updated reference to signal list in "signal events" section #9323
emadb wants to merge 3 commits into
nodejs:masterfrom
emadb:patch-1

Conversation

emadb commented Oct 27, 2016

Copy link
Copy Markdown
Contributor

Documentation is changed or added.
Changed the reference from sigaction(2) to signal(7) like requested in issue #9309

Updated reference to signal list in "signal events" section
05a2e66 
Changed the reference from sigaction(2) to signal(7) like requested in issue nodejs#9309
nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Oct 27, 2016
cjihrig requested changes Oct 27, 2016
View reviewed changes
Comment thread doc/api/process.md Outdated

Signal events will be emitted when the Node.js process receives a signal. Please
refer to sigaction(2) for a listing of standard POSIX signal names such as
refer to [signal(7)](http://man7.org/linux/man-pages/man7/signal.7.html) for a listing of standard POSIX signal names such as

cjihrig Oct 27, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you move the URL to the bottom of the page with the others.

mscdex commented Oct 27, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

I don't think a link needs to be explicitly added since the doc tools automatically insert links when they see man page references. So just changing the 'sigaction(2)' to 'signal(7)' should be enough.

emadb commented Oct 27, 2016

Copy link
Copy Markdown
Contributor Author

@mscdex didn't about it. I wait for a feedback from @cjihrig if I have to remove the link.
Thx (this is my very first try to help).

cjihrig commented Oct 27, 2016

Copy link
Copy Markdown
Contributor

Sorry @emadb, I didn't remember that the doc tools could recognize man pages. @mscdex is right.

Removed the link
c5b29a2 
I removed the link since the doc tool automatically add link to man pages.

mscdex commented Oct 27, 2016

Copy link
Copy Markdown
Contributor

LGTM

sam-github commented Oct 27, 2016

Copy link
Copy Markdown
Contributor

@cjihrig I think you have to mark your requested changes as having been made (I'm not loving the new review system yet).

LGTM

sam-github pushed a commit that referenced this pull request Oct 27, 2016
doc: reference signal(7) for the list of signals
6893f3c 
Fixes: #9309
PR-URL: #9323
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

sam-github commented Oct 27, 2016

Copy link
Copy Markdown
Contributor

Landed in 6893f3c, thanks @emadb

sam-github closed this Oct 27, 2016
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
doc: reference signal(7) for the list of signals
c745890 
Fixes: #9309
PR-URL: #9323
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
evanlucas mentioned this pull request Nov 3, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Nov 11, 2016
doc: reference signal(7) for the list of signals
ec90f73 
Fixes: #9309
PR-URL: #9323
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Nov 11, 2016
doc: reference signal(7) for the list of signals
f472c09 
Fixes: #9309
PR-URL: #9323
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
This was referenced Nov 22, 2016
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL