FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

cares: sync with upstream, fully adopt v1.12.0 by rvagg · Pull Request #9332 · nodejs/node · GitHub

/ node Public

cares: sync with upstream, fully adopt v1.12.0 - #9332

Closed
rvagg wants to merge 7 commits into
nodejs:masterfrom
rvagg:c-ares-1.12.0
ConversationCommits (7)ChecksFiles changed
Closed

cares: sync with upstream, fully adopt v1.12.0#9332
rvagg wants to merge 7 commits into
nodejs:masterfrom
rvagg:c-ares-1.12.0

Conversation

rvagg commented Oct 28, 2016

Copy link
Copy Markdown
Member

Not a big change but previous sync's have been piecemeal so this is a full job. I've also redone most of the config headers in config/ (haven't touched the AIX one but it still compiles and passes).

Passing CI @ https://ci.nodejs.org/job/node-test-commit/5830/ minus unrelated freebsd failures.

I believe this is ABI and API stable so could be backported through to v4.x.

mscdex added the cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. label Oct 28, 2016
mscdex mentioned this pull request Oct 28, 2016
Closed

rvagg commented Oct 28, 2016

Copy link
Copy Markdown
Member Author

@indutny @bnoordhuis I think you two might be best equipped to review this one

sam-github commented Oct 28, 2016

Copy link
Copy Markdown
Contributor

@rvagg @richardlau should the AIX header be updated, too, or is it just cosmetic?

gibfahn commented Oct 28, 2016

Copy link
Copy Markdown
Member

cc/ @nodejs/platform-aix

richardlau commented Oct 28, 2016

Copy link
Copy Markdown
Member

Looking at the changes to the config/ headers for the other platforms in this pull request I think the AIX header should be updated too.

@rvagg Looks like this change also adds deps/cares/LICENSE.md -- Presumably we want to update the license-builder.sh script to use this file and regenerate the license?

rvagg commented Oct 29, 2016

Copy link
Copy Markdown
Member Author

updated license-builder.sh, thanks @richardlau, that's why I included LICENSE.md after all!

rvagg commented Oct 29, 2016

Copy link
Copy Markdown
Member Author

I've updated AIX config, I had trouble getting access to an AIX machine yesterday but I've figured out my problem. PTAL IBMers.

gibfahn commented Oct 29, 2016

Copy link
Copy Markdown
Member

Another CI: https://ci.nodejs.org/job/node-test-pull-request/4734/

jasnell commented Mar 24, 2017

Copy link
Copy Markdown
Member

Ping... updates?

jasnell added the stalled Issues and PRs that are stalled. label Mar 24, 2017

gibfahn commented Mar 24, 2017

Copy link
Copy Markdown
Member

cc/ @nodejs/platform-aix regarding the AIX header update.

fhinkel commented May 26, 2017

Copy link
Copy Markdown
Contributor

@rvagg Any idea if the CI failures are related? Is this ready to land?

mscdex commented Jun 24, 2017

Copy link
Copy Markdown
Contributor

c-ares 1.13.0 is available now. If we can land that instead, that will also take care of #13897 in the process.

kasicka commented Jun 27, 2017

Copy link
Copy Markdown

Is there any ETA on this?

BridgeAR commented Aug 26, 2017

Copy link
Copy Markdown
Member

@rvagg are you going to follow up on this?

BridgeAR commented Sep 12, 2017

Copy link
Copy Markdown
Member

Closing this due to a long inactivity. Please feel free to reopen if you want to follow up on this @rvagg

BridgeAR closed this Sep 12, 2017
rvagg mentioned this pull request Sep 13, 2017
Closed

rvagg commented Sep 13, 2017

Copy link
Copy Markdown
Member Author

Thanks for the nudge @BridgeAR! Sorry for my unresponsiveness here, I'm trying to get back on the 🐴 now. Opened at new PR @ #15378 with 1.13.0 but it still has a couple of failures. Any additional help there would be appreciated.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. stalled Issues and PRs that are stalled.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL