test: remove timer in test-dgram-send-empty-array - #9361
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
addaleax
approved these changes
Oct 29, 2016
addaleax
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
The timer is not necessary. The test will timeout via the test harness if the test fails. This should resolve spurious CI failures.
Copy link
Copy Markdown
Member
Author
|
GREEN! CI IS GREEN! |
Sorry, something went wrong.
santigimeno
approved these changes
Oct 30, 2016
cjihrig
approved these changes
Oct 30, 2016
jasnell
approved these changes
Oct 30, 2016
evanlucas
approved these changes
Nov 1, 2016
lpinca
approved these changes
Nov 1, 2016
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 2, 2016
The timer is not necessary. The test will timeout via the test harness if the test fails. This should resolve spurious CI failures. PR-URL: nodejs#9361 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Nov 3, 2016
The timer is not necessary. The test will timeout via the test harness if the test fails. This should resolve spurious CI failures. PR-URL: #9361 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2016
The timer is not necessary. The test will timeout via the test harness if the test fails. This should resolve spurious CI failures. PR-URL: #9361 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test dgram
Description of change
The timer is not necessary. The test will timeout via the test harness
if the test fails. This should resolve spurious CI failures.