FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: increase test coverage for lib/zlib.js by Trott · Pull Request #9366 · nodejs/node · GitHub

/ node Public

test: increase test coverage for lib/zlib.js - #9366

Closed
Trott wants to merge 3 commits into
nodejs:masterfrom
Trott:zlib-coverage
ConversationCommits (3)ChecksFiles changed
Closed

test: increase test coverage for lib/zlib.js#9366
Trott wants to merge 3 commits into
nodejs:masterfrom
Trott:zlib-coverage

Conversation

Trott commented Oct 30, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test zlib

Description of change

Add tests for constructor behavior and parameter validation. Remove condition check that cannot be triggered (nothing is greater than Infinity).

test: increase test coverage for lib/zlib.js
36e848c 
Add tests for constructor behavior and parameter validation. Remove
condition check that cannot be triggered (nothing is greater than
`Infinity`).
Trott added zlib Issues and PRs related to the zlib subsystem. test Issues and PRs related to the tests. labels Oct 30, 2016
nodejs-github-bot added the zlib Issues and PRs related to the zlib subsystem. label Oct 30, 2016

Trott commented Oct 30, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/4739/

cjihrig reviewed Oct 30, 2016
View reviewed changes
Comment thread test/parallel/test-zlib-deflate-constructors.js Outdated
/^Error: Invalid chunk size: -Infinity$/
);

// Confrim that maximum chunk size cannot be exceeded because it is `Infinity`.

cjihrig Oct 30, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

typo: Confrim

cjihrig reviewed Oct 30, 2016
View reviewed changes
Comment thread test/parallel/test-zlib-deflate-constructors.js Outdated
);

// Confrim that maximum chunk size cannot be exceeded because it is `Infinity`.
assert.deepEqual(zlib.constants.Z_MAX_CHUNK, Infinity);

cjihrig Oct 30, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should this be strictEqual() instead?

cjihrig commented Oct 30, 2016

Copy link
Copy Markdown
Contributor

LGTM with a couple nits.

Trott commented Oct 30, 2016

Copy link
Copy Markdown
Member Author

Nits addressed. Thanks.

CI again: https://ci.nodejs.org/job/node-test-pull-request/4742/

JungMinu commented Nov 2, 2016

Copy link
Copy Markdown
Member

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Nov 2, 2016
test: increase test coverage for lib/zlib.js
3eea668 
Add tests for constructor behavior and parameter validation. Remove
condition check that cannot be triggered (nothing is greater than
`Infinity`).

PR-URL: nodejs#9366
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Trott commented Nov 2, 2016

Copy link
Copy Markdown
Member Author

Lnaded in 3eea668

Trott closed this Nov 2, 2016
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
test: increase test coverage for lib/zlib.js
e696bc3 
Add tests for constructor behavior and parameter validation. Remove
condition check that cannot be triggered (nothing is greater than
`Infinity`).

PR-URL: #9366
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas mentioned this pull request Nov 3, 2016
Merged

MylesBorins commented Nov 22, 2016

Copy link
Copy Markdown
Contributor

This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport

Trott commented Jul 18, 2017

Copy link
Copy Markdown
Member Author

Updated label to dont-land-on-v6.x because depends on zlib.constants not in v6.x.

Trott deleted the zlib-coverage branch January 13, 2022 22:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
JungMinu JungMinu approved these changes

Assignees

No one assigned

Labels

test Issues and PRs related to the tests. zlib Issues and PRs related to the zlib subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL