tools: enforce function name matching in linter - #9408
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ESLint has a `func-name-matching` rule that requires that function names match the variable or property to which they are being assigned. The code base currently has 100% compliance with this rule. Enable the rule to keep it that way.
silverwind
approved these changes
Nov 1, 2016
silverwind
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, I'm surprised it passes as-is.
Sorry, something went wrong.
cjihrig
approved these changes
Nov 1, 2016
targos
approved these changes
Nov 2, 2016
Copy link
Copy Markdown
Member
|
hmm.. I believe I've seen a couple of cases in the recent function naming PRs that could violate this but in theory, LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@jasnell Then I guess we just need to make sure we run the linter on those PRs before we merge them? |
Sorry, something went wrong.
gibfahn
approved these changes
Nov 2, 2016
not-an-aardvark
approved these changes
Nov 3, 2016
princejwesley
approved these changes
Nov 3, 2016
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 4, 2016
ESLint has a `func-name-matching` rule that requires that function names match the variable or property to which they are being assigned. The code base currently has 100% compliance with this rule. Enable the rule to keep it that way. PR-URL: nodejs#9408 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Nov 7, 2016
ESLint has a `func-name-matching` rule that requires that function names match the variable or property to which they are being assigned. The code base currently has 100% compliance with this rule. Enable the rule to keep it that way. PR-URL: #9408 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Copy link
Copy Markdown
Contributor
|
@Trott do you want to manually backport this rule + fixes to v4 and v6? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@thealphanerd Unless you think otherwise, I think it's OK if this doesn't land in v4 and v6. I'll change the labels. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
tools
Description of change
ESLint has a func-name-matching rule that requires that function names
match the variable or property to which they are being assigned.
The code base currently has 100% compliance with this rule.
Enable the rule to keep it that way.