FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: default --icu_case_mapping on as a v8 option by srl295 · Pull Request #9454 · nodejs/node · GitHub

/ node Public

src: default --icu_case_mapping on as a v8 option - #9454

Closed
srl295 wants to merge 1 commit into
nodejs:masterfrom
srl295:default_icu_case_mapping
ConversationCommits (1)ChecksFiles changed
Closed

src: default --icu_case_mapping on as a v8 option#9454
srl295 wants to merge 1 commit into
nodejs:masterfrom
srl295:default_icu_case_mapping

Conversation

srl295 commented Nov 3, 2016

Copy link
Copy Markdown
Member
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Description of change
  • toLocaleUpperCase() and toLocaleLowerCase() do not function properly
    without this flag.
  • basic test case. The test case would fail if --no_icu_case_mapping
    was set.

Fixes: #9445

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 3, 2016
srl295 self-assigned this Nov 3, 2016
srl295 added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 3, 2016
mscdex added i18n-api Issues and PRs related to the i18n implementation. v8 engine Issues and PRs related to the V8 dependency. labels Nov 3, 2016
bnoordhuis approved these changes Nov 3, 2016
View reviewed changes

bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with a style nit

Comment thread src/node.cc Outdated

bnoordhuis Nov 3, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you capitalize the comment?

srl295 commented Nov 3, 2016

Copy link
Copy Markdown
Member Author

@evanlucas also said

I wonder if we could just bake that flag in to node.gyp

srl295 commented Nov 4, 2016 •
edited
Loading

Copy link
Copy Markdown
Member Author

I don't know why the linter is failing in the automated build. Can't reproduce… any ideas @nodejs/build ?

$ make lint-ci
./node tools/jslint.js  -f tap -o test-eslint.tap \
        benchmark lib test tools
Total errors found: 0

update seems to be working now.

src: default --icu_case_mapping on as a v8 option
0d71729 
* toLocaleUpperCase() and toLocaleLowerCase() do not function properly
without this flag.
* basic test case. The test case would fail if `--no_icu_case_mapping`
was set.

Fixes: nodejs#9445
PR-URL: nodejs#9454
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
srl295 force-pushed the default_icu_case_mapping branch from a5c90e8 to 0d71729 Compare November 4, 2016 15:55

bnoordhuis commented Nov 4, 2016

Copy link
Copy Markdown
Member

I wonder if we could just bake that flag in to node.gyp

Could for sure, but we don't do that for other flags.

srl295 commented Nov 4, 2016

Copy link
Copy Markdown
Member Author

Landed in 1a55e9a

srl295 closed this Nov 4, 2016
srl295 deleted the default_icu_case_mapping branch November 4, 2016 16:50
srl295 added a commit that referenced this pull request Nov 4, 2016
src: default --icu_case_mapping on as a v8 option
1a55e9a 
* toLocaleUpperCase() and toLocaleLowerCase() do not function properly
without this flag.
* basic test case. The test case would fail if `--no_icu_case_mapping`
was set.

Fixes: #9445
PR-URL: #9454
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
evanlucas pushed a commit that referenced this pull request Nov 7, 2016
src: default --icu_case_mapping on as a v8 option
b1ef638 
* toLocaleUpperCase() and toLocaleLowerCase() do not function properly
without this flag.
* basic test case. The test case would fail if `--no_icu_case_mapping`
was set.

Fixes: #9445
PR-URL: #9454
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
evanlucas mentioned this pull request Nov 7, 2016
Merged
gibfahn mentioned this pull request Apr 24, 2017
Closed
31 tasks

MylesBorins commented May 15, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

landed this on v6.x and got the error "Error: unrecognized flag --icu_case_mapping"

not landing for now. LMK if we should consider it

srl295 commented Aug 31, 2017

Copy link
Copy Markdown
Member Author

@MylesBorins no, incompatible with older v8. And new v8 :)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
jasnell jasnell approved these changes

Assignees

srl295

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. i18n-api Issues and PRs related to the i18n implementation. semver-minor PRs that contain new features and should be released in the next minor version. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL