test: fix flaky test-force-repl-with-eval - #9460
Merged
santigimeno merged 1 commit intoNov 6, 2016
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
cjihrig
approved these changes
Nov 4, 2016
Trott
approved these changes
Nov 5, 2016
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
targos
approved these changes
Nov 5, 2016
Remove the timer just in case the test takes longer to complete. PR-URL: nodejs#9460 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Nov 7, 2016
Remove the timer just in case the test takes longer to complete. PR-URL: #9460 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2016
Remove the timer just in case the test takes longer to complete. PR-URL: #9460 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change
Remove the timer just in case the test takes longer to complete.
It has already failed on the smartos bot: https://ci.nodejs.org/job/node-test-commit-smartos/5075/nodes=smartos14-64/consoleFull
not ok 324 parallel/test-force-repl-with-eval # /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-64/test/parallel/test-force-repl-with-eval.js:10 # throw new Error('timeout!'); # ^ # # Error: timeout! # at Timeout._onTimeout (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-64/test/parallel/test-force-repl-with-eval.js:10:9) # at ontimeout (timers.js:365:14) # at tryOnTimeout (timers.js:237:5) # at Timer.listOnTimeout (timers.js:207:5)