test: remove watchdog in test-debug-signal-cluster - #9476
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
test-debug-signal-cluster contains a watchdog timer that results in false positives in CI. Remove the watchdog timer and let the test runner determine that the test has timed out.
targos
approved these changes
Nov 5, 2016
cjihrig
approved these changes
Nov 5, 2016
santigimeno
approved these changes
Nov 6, 2016
jasnell
approved these changes
Nov 7, 2016
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 8, 2016
test-debug-signal-cluster contains a watchdog timer that results in false positives in CI. Remove the watchdog timer and let the test runner determine that the test has timed out. PR-URL: nodejs#9476 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Nov 22, 2016
test-debug-signal-cluster contains a watchdog timer that results in false positives in CI. Remove the watchdog timer and let the test runner determine that the test has timed out. PR-URL: #9476 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 1, 2016
test-debug-signal-cluster contains a watchdog timer that results in false positives in CI. Remove the watchdog timer and let the test runner determine that the test has timed out. PR-URL: #9476 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 1, 2016
test-debug-signal-cluster contains a watchdog timer that results in false positives in CI. Remove the watchdog timer and let the test runner determine that the test has timed out. PR-URL: #9476 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test debugger
Description of change
test-debug-signal-cluster contains a watchdog timer that results in
false positives in CI. Remove the watchdog timer and let the test runner
determine that the test has timed out.
Example failure: https://ci.nodejs.org/job/node-test-commit-smartos/5075/nodes=smartos14-64/console
not ok 217 parallel/test-debug-signal-cluster # got pids [81560,84923,85367] # # assert.js:85 # throw new assert.AssertionError({ # ^ # AssertionError: test timed out # at Object.exports.fail (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-64/test/common.js:443:10) # at Timeout.testTimedOut [as _onTimeout] (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-64/test/parallel/test-debug-signal-cluster.js:69:10) # at ontimeout (timers.js:365:14) # at Timer.unrefdHandle (timers.js:466:3) # > all workers are running # > Starting debugger agent. # > Debugger listening on 127.0.0.1:12646 # > Starting debugger agent. --- duration_ms: 7.124CI stress test on current master showing failures: https://ci.nodejs.org/job/node-stress-single-test/1053/nodes=smartos14-64/console
CI stress test on this change (will hopefully come up green): https://ci.nodejs.org/job/node-stress-single-test/1054/nodes=smartos14-64/console