test: improve test-debugger-util-regression - #9490
Merged
santigimeno merged 1 commit intoNov 7, 2016
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Trott
approved these changes
Nov 6, 2016
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM if CI is ✅
Sorry, something went wrong.
cjihrig
approved these changes
Nov 6, 2016
jasnell
approved these changes
Nov 7, 2016
Avoid the `exit` command to be sent more than once. It prevents from undesired errors emitted on `proc.stdin`. Remove the watchdog timer so the test does not fail in case it takes longer to complete. PR-URL: nodejs#9490 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
santigimeno
force-pushed
the
fix_debugger_util_regression
branch
from
b054dc4 to
1b88989
Compare
November 7, 2016 12:33
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
evanlucas
pushed a commit
that referenced
this pull request
Nov 7, 2016
Avoid the `exit` command to be sent more than once. It prevents from undesired errors emitted on `proc.stdin`. Remove the watchdog timer so the test does not fail in case it takes longer to complete. PR-URL: #9490 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2016
Avoid the `exit` command to be sent more than once. It prevents from undesired errors emitted on `proc.stdin`. Remove the watchdog timer so the test does not fail in case it takes longer to complete. PR-URL: #9490 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2016
Avoid the `exit` command to be sent more than once. It prevents from undesired errors emitted on `proc.stdin`. Remove the watchdog timer so the test does not fail in case it takes longer to complete. PR-URL: #9490 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
Avoid the exit command to be sent more than once. It prevents from
undesired errors emitted on proc.stdin.
Remove the watchdog timer so the test does not fail in case it takes
longer to complete.
There was a failure on the CI freebsd box caused by the watchdog timer: https://ci.nodejs.org/job/node-test-commit-freebsd/5177/nodes=freebsd10-64/console
not ok 236 parallel/test-debugger-util-regression # # assert.js:85 # throw new assert.AssertionError({ # ^ # AssertionError: the program should not hang # at Object.exports.fail (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/common.js:443:10) # at Timeout.fail [as _onTimeout] (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-debugger-util-regression.js:23:10) # at ontimeout (timers.js:365:14) # at tryOnTimeout (timers.js:237:5) # at Timer.listOnTimeout (timers.js:207:5)