0.12 npm@2 update to latest (v2.15.11) - #9619
Merged
Fishrock123 merged 1 commit intoNov 18, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
MylesBorins
approved these changes
Nov 15, 2016
MylesBorins
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM tests pass locally
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
did some manual testing locally and I can't find a fault with this, so lgtm |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@rvagg want me to land it or would you prefer to do it along with the release? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@Fishrock123 would you mind landing it on v0.12-staging please? |
Sorry, something went wrong.
jasnell
approved these changes
Nov 18, 2016
jasnell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Rubber stamp LGTM
Sorry, something went wrong.
Fishrock123
added a commit
to Fishrock123/node
that referenced
this pull request
Nov 18, 2016
Refs: nodejs/Release#143 PR-URL: nodejs#9619 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Dec 22, 2016
Refs: nodejs/Release#143 PR-URL: nodejs/node#9619 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
deps, npm
Description of change
See nodejs/Release#143. This is an update to the latest npm@2 (v2.15.11) for 0.12.x.
R=@thealphanerd, @rvagg, also @nodejs/npm if you could verify I did this correctly.