FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add Working Group revocation text by williamkapke · Pull Request #9656 · nodejs/node · GitHub

/ node Public

doc: add Working Group revocation text - #9656

Closed
williamkapke wants to merge 1 commit into
masterfrom
unknown repository
Closed

doc: add Working Group revocation text#9656
williamkapke wants to merge 1 commit into
masterfrom
unknown repository

Conversation

Copy link
Copy Markdown
Contributor
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

Recently, the Roadmap Working Group was dissolved. I thought we followed a defined process for making that happen- but I was incorrect. The problem is that I confused the text in the TSC's text for dissolving a Top Level Working Group as being the process for a Core Working Group. They are identical EXCEPT that the TSC's version ends with:

A Working Group can be dissolved either through consensus of the Working Group membership or normal TSC motion and vote.

So- Core Working Groups actually do not (technically) have a defined way to dissolve them right now. This is likely just an error of docs being shuffled around.

This PR just adds that same statement to Core's version of WORKING_GROUPS.md.

This will need to be approved by the CTC.

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 17, 2016
Comment thread WORKING_GROUPS.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Incorrect, we can't actually dissolve it but we can revoke it as being formally responsible for what it was chartered for.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This did just happen with the Roadmap WG.

Whether it is call "dissolving" or "revoking" ... ¯_(ツ)_/¯ ... but the process should be defined and probably should match the TSC wording (so maybe the TSC doc needs to change too).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It was in a formal sense revoked and in a slightly less formal sense dissolved... (by half of it's members?)

The language does matter.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Since we're pretty explicit elsewhere (I think, at least) that the only power the CTC maintains over a WG is to revoke its charter, I think we should use the same language here. I agree the difference is subtle, but consistency will help reduce the likelihood that someone interprets one document as saying one thing and another document as saying something different.

Copy link
Copy Markdown
Contributor Author

Ok @Trott & @Fishrock123 I changed it to revoked

williamkapke changed the title doc: add Working Group dissolution text doc: add Working Group revocation text Dec 2, 2016

Trott commented Dec 2, 2016

Copy link
Copy Markdown
Member

@nodejs/ctc This is a governance change, so if we could get a bunch of CTC members to LGTM this here, it means we won't have to take it up during a meeting.

Trott commented Dec 2, 2016

Copy link
Copy Markdown
Member

Clarification: This isn't a governance change, per se. It is a a change to the governance doc. But it is a clarification, not a change.

Comment thread WORKING_GROUPS.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Isn't it members here?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

How about instead of:

back in to the CTC. A Working Group can be revoked either through consensus of the Working Group membership or normal CTC motion and vote.

...something more like this:

back into the CTC. This can be done by revoking the Working Group's charter. A Working Group's charter can be revoked either by consensus of the Working Group's members or by a CTC vote.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think that's fine @Trott ... but then we should update the TSC's version too huh?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You mean because it's a verbatim or near-verbatim copy? In that case, maybe pick one location and link to it from the other?

Copy link
Copy Markdown
Contributor Author

Text revised to remove another reference to the word dissolve and to provide (hopefully) better wording.

Please re-review.

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jasnell pushed a commit that referenced this pull request Dec 28, 2016
PR-URL: #9656
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

jasnell commented Dec 28, 2016

Copy link
Copy Markdown
Member

Landed in 14709e5

jasnell closed this Dec 28, 2016
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
PR-URL: #9656
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
PR-URL: #9656
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
PR-URL: #9656
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
PR-URL: #9656
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
PR-URL: #9656
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
PR-URL: #9656
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Jan 24, 2017
Trott removed the ctc-review label Jan 31, 2017
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
PR-URL: #9656
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
PR-URL: #9656
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.


Back | FazBrowse Home | New Git URL