FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add italoacasas to collaborators by italoacasas · Pull Request #9677 · nodejs/node · GitHub

/ node Public

doc: add italoacasas to collaborators - #9677

Closed
italoacasas wants to merge 1 commit into
nodejs:masterfrom
italoacasas:doc/add-italoacasas-to-collaborators
ConversationCommits (1)ChecksFiles changed
Closed

doc: add italoacasas to collaborators#9677
italoacasas wants to merge 1 commit into
nodejs:masterfrom
italoacasas:doc/add-italoacasas-to-collaborators

Conversation

italoacasas commented Nov 18, 2016

Copy link
Copy Markdown
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Adding italoacasas to collaborators

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 18, 2016
addaleax approved these changes Nov 18, 2016
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM and Welcome!

Trott commented Nov 18, 2016

Copy link
Copy Markdown
Member

LGTM

italoacasas commented Nov 18, 2016

Copy link
Copy Markdown
Author

CI: https://ci.nodejs.org/job/node-test-pull-request/4888/console

lpinca approved these changes Nov 18, 2016
View reviewed changes

lpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

MylesBorins commented Nov 18, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

LGTM. For future reference @italoacasas there isn't a need to run CI for small doc fixes like this.

edit: Also congrats 🎉

italoacasas pushed a commit that referenced this pull request Nov 18, 2016
doc: add italoacasas to collaborators
38813c1 
PR-URL: #9677
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

italoacasas commented Nov 18, 2016

Copy link
Copy Markdown
Author

Landed in: 38813c1. Thanks everyone

Trott commented Nov 18, 2016

Copy link
Copy Markdown
Member

@thealphanerd I always have new collaborators start a CI on these onboarding PRs to confirm that they know how to start a CI job and that there isn't any issue with permissions on Jenkins etc.

MylesBorins commented Nov 18, 2016

Copy link
Copy Markdown
Contributor

@Trott thanks for the heads up

@italoacasas sorry for the confusion there.

MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
doc: add italoacasas to collaborators
2b2dde8 
PR-URL: #9677
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
doc: add italoacasas to collaborators
ee2ebba 
PR-URL: #9677
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott commented Nov 18, 2016

Copy link
Copy Markdown
Member

@thealphanerd I guess I should also instruct them to add the relevant land-on LTS labels on these things too, eh?

MylesBorins pushed a commit that referenced this pull request Nov 19, 2016
doc: add italoacasas to collaborators
eeaadcd 
PR-URL: #9677
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit that referenced this pull request Nov 22, 2016
doc: add italoacasas to collaborators
425a864 
PR-URL: #9677
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Nov 22, 2016
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
lpinca lpinca approved these changes
+1 more reviewer
MylesBorins MylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL