| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Commit 93a44d5 ("src: fix deferred events not working with -e") defers evaluation of the script to the next tick. A side effect of that change is that 'beforeExit' listeners run before the actual script. 'beforeExit' is emitted when the event loop is empty but process.nextTick() does not ref the event loop. Fix that by using setImmediate(). Because it is implemented in terms of a uv_check_t handle, it interacts with the event loop properly. Ref: nodejs#9680 Fixes: nodejs#8534 PR-URL: nodejs#8821 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
ping @MylesBorins ... is this still in consideration for v4? |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Checklist
Affected core subsystem(s)
test, lib
Description of change
This is an attempted backport of c5b07d4 to v4.x
It involved manually recreating the entire commit, as bootstrap_node.js does not exist in v4.x and the stack traces for the tests are quite different.
Unfortunately when running the tests we are seeing a failure in test/parallel/test-debug-brk.js. The node process for that test is not exiting and it is leaving phantom processes running 👻
Please do not run this in CI until we have figured out what is going on with the phantom processes.
@bnoordhuis do you have any idea why this is happening?
/cc @nodejs/lts