crypto: fix faulty logic in iv size check (backport #9032) - #9687
crypto: fix faulty logic in iv size check (backport #9032)#9687sam-github wants to merge 1 commit into
Conversation
Sorry, something went wrong.
Fix a regression introduced in commit 2996b5c ("crypto: Allow GCM ciphers to have a longer IV length") from April 2016 where a misplaced parenthesis in a 'is ECB cipher?' check made it possible to use empty IVs with non-ECB ciphers. Also fix some exit bugs in test/parallel/test-crypto-authenticated.js that were introduced in commit 4a40832 ("test: cleanup IIFE tests") where removing the IFFEs made the test exit prematurely instead of just skipping subtests. PR-URL: nodejs#9032 Refs: nodejs#6376 Refs: nodejs#9024 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
bnoordhuis
left a comment
There was a problem hiding this comment.
Can I sign off on my own changes? Of course I can, LGTM.
Out of curiosity, where were the merge conflicts?
Sorry, something went wrong.
|
@bnoordhuis they were all in the tests, because of the function to block rewrite. which probably means the fn to block rewrite should have been backported. |
Sorry, something went wrong.
|
I think this is causing the CI failures we are seeing on AIX... backing it out for now |
Sorry, something went wrong.
|
ugh... I was mistaken, this had nothing to do with those aix failure. Running CI. If green aside from expected failures I'll re land this. |
Sorry, something went wrong.
backport of #9032
Checklist
Affected core subsystem(s)
Description of change
Fix a regression introduced in commit 2996b5c ("crypto: Allow GCM
ciphers to have a longer IV length") from April 2016 where a misplaced
parenthesis in a 'is ECB cipher?' check made it possible to use empty
IVs with non-ECB ciphers.
Also fix some exit bugs in test/parallel/test-crypto-authenticated.js
that were introduced in commit 4a40832 ("test: cleanup IIFE tests")
where removing the IFFEs made the test exit prematurely instead of just
skipping subtests.
PR-URL: #9032
Refs: #6376
Refs: #9024
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Fedor Indutny fedor@indutny.com
Reviewed-By: Shigeki Ohtsu ohtsu@ohtsu.org