doc: child_process .stdio accepts a String type - #9701
Conversation
Sorry, something went wrong.
Document that `execFileSync`, `execSync` and `spawnSync` also supports `stdio` as an Array. Fixes: nodejs#9636
| * `input` {String|Buffer} The value which will be passed as stdin to the spawned process | ||
| - supplying this value will override `stdio[0]` | ||
| * `stdio` {Array} Child's stdio configuration. | ||
| * `stdio` {String|Array} Child's stdio configuration. |
There was a problem hiding this comment.
The default is pipe here as well.
Sorry, something went wrong.
Fishrock123
left a comment
There was a problem hiding this comment.
Addressing @thefourtheye's comment would be nice.
Sorry, something went wrong.
|
@thefourtheye thanks, I've addressed your comment. |
Sorry, something went wrong.
addaleax
left a comment
There was a problem hiding this comment.
LGTM … I guess we’ll just cherry-pick the 2nd commit onto master after this?
Sorry, something went wrong.
|
@addaleax Ya, that will work. But not directly right? Commits have to go through the PR process. |
Sorry, something went wrong.
|
@thefourtheye Yeah, I was asking because the extra commit is going through a review process (this one). But since it doesn’t apply 100 % cleanly I guess another PR is fine, too. |
Sorry, something went wrong.
|
@addaleax the default is already documented on master. : ) |
Sorry, something went wrong.
Document that `execFileSync`, `execSync` and `spawnSync` also supports `stdio` as an Array. PR-URL: #9701 Fixes: #9636 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Document that `execFileSync`, `execSync` and `spawnSync` also supports `stdio` as an Array. PR-URL: #9701 Fixes: #9636 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Checklist
Affected core subsystem(s)
doc
Description of change
Document that execFileSync, execSync and spawnSync also supports stdio as an Array for v4.x.
Fixes: #9636
See master branch pull request here #9637