FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: replace equal with strictEqual in test-freelist.js by edsadr · Pull Request #9910 · nodejs/node · GitHub

/ node Public

test: replace equal with strictEqual in test-freelist.js - #9910

Closed
edsadr wants to merge 1 commit into
nodejs:masterfrom
edsadr:test-freelist
Closed

test: replace equal with strictEqual in test-freelist.js#9910
edsadr wants to merge 1 commit into
nodejs:masterfrom
edsadr:test-freelist

Conversation

edsadr commented Dec 1, 2016

Copy link
Copy Markdown
Contributor
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Improving asserts in test-freelist.js

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
mscdex added the lib / src Issues and PRs related to general changes in the lib or src directory. label Dec 1, 2016

Trott commented Dec 1, 2016

Copy link
Copy Markdown
Member

Trott commented Dec 5, 2016

Copy link
Copy Markdown
Member

jasnell pushed a commit that referenced this pull request Dec 5, 2016
Improving asserts in test-freelist.js

PR-URL: #9910
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Dec 5, 2016

Copy link
Copy Markdown
Member

Landed in 9042a91. Thank you for the PR and for participating in the code-and-learn!

jasnell closed this Dec 5, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
Improving asserts in test-freelist.js

PR-URL: #9910
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
Improving asserts in test-freelist.js

PR-URL: nodejs#9910
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
Improving asserts in test-freelist.js

PR-URL: nodejs#9910
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Improving asserts in test-freelist.js

PR-URL: #9910
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Dec 21, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. lib / src Issues and PRs related to general changes in the lib or src directory. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants


Back | FazBrowse Home | New Git URL