test: change assert.equal to assert.strictEqual - #9956
Closed
crokita wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
First line of commit message is too long, see the commit message guidelines here. |
Sorry, something went wrong.
jasnell
approved these changes
Dec 5, 2016
jasnell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. The commits will need to be squashed and a new-line needs to be added at the end of the file to pass linting.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
ping @crokita: Can you add a newline to the end of the file? Even better if you can squash the commits into a single commit, but that can also be done by whoever lands the change. |
Sorry, something went wrong.
crokita
force-pushed
the
test-cluster-fix
branch
from
bde2cce to
30d5451
Compare
December 22, 2016 15:16
Copy link
Copy Markdown
Contributor
Author
|
Yep! Updated the branch. Does this look okay @Trott ? |
Sorry, something went wrong.
Trott
approved these changes
Dec 22, 2016
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM if CI is ✅
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
italoacasas
approved these changes
Dec 23, 2016
italoacasas
pushed a commit
that referenced
this pull request
Dec 23, 2016
- Using assert.strictEqual instead assert.equal PR-URL: #9956 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
targos
pushed a commit
that referenced
this pull request
Dec 26, 2016
- Using assert.strictEqual instead assert.equal PR-URL: #9956 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 28, 2016
- Using assert.strictEqual instead assert.equal PR-URL: #9956 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
- Using assert.strictEqual instead assert.equal PR-URL: #9956 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
- Using assert.strictEqual instead assert.equal PR-URL: #9956 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
- Using assert.strictEqual instead assert.equal PR-URL: #9956 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
- Using assert.strictEqual instead assert.equal PR-URL: #9956 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 1, 2017
- Using assert.strictEqual instead assert.equal PR-URL: #9956 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
Use assert.strictEqual() instead of assert.equal() for lines 11, 12, 13, 14, 21, 22, 23, 24, 28