FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: replace var with const/let and use common.mustCall for cb by outsideris · Pull Request #9959 · nodejs/node · GitHub

/ node Public

test: replace var with const/let and use common.mustCall for cb - #9959

Closed
outsideris wants to merge 1 commit into
nodejs:masterfrom
outsideris:code-and-learn-1
ConversationCommits (1)ChecksFiles changed
Closed

test: replace var with const/let and use common.mustCall for cb#9959
outsideris wants to merge 1 commit into
nodejs:masterfrom
outsideris:code-and-learn-1

Conversation

outsideris commented Dec 1, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change
  • replace var with const and let
  • use common.mustCall for callbacks
  • remove process.on('exit') because all callbacks are wrapped by common.mustCall

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
mscdex added the tls Issues and PRs related to the tls subsystem. label Dec 1, 2016
imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
princejwesley reviewed Dec 1, 2016
View reviewed changes

princejwesley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Merge commits as single commit!

outsideris commented Dec 1, 2016

Copy link
Copy Markdown
Contributor Author

@princejwesley I merged them.

cjihrig approved these changes Dec 5, 2016
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with one small nit.

Comment thread test/parallel/test-tls-cnnic-whitelist.js Outdated

cjihrig Dec 5, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you move this line below the hasCrypto check?

Trott commented Dec 8, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5324/

test: replace var with const/let and use common.mustCall
1c38ce2 
remove process.on('exit') because all callbacks are
wrapped by common.mustCall.

outsideris commented Dec 9, 2016

Copy link
Copy Markdown
Contributor Author

As @cjihrig said, I moved the require statement.

Trott commented Dec 9, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5334/

silverwind commented Dec 16, 2016

Copy link
Copy Markdown
Contributor

Thanks! Landed with slightly trimmed commit message in 4913acd.

silverwind closed this Dec 16, 2016
silverwind pushed a commit that referenced this pull request Dec 16, 2016
test: use const/let and common.mustCall
4913acd 
remove process.on('exit') because all callbacks are
wrapped by common.mustCall.

PR-URL: #9959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

outsideris commented Dec 17, 2016

Copy link
Copy Markdown
Contributor Author

@silverwind Thanks!

italoacasas pushed a commit that referenced this pull request Dec 17, 2016
test: use const/let and common.mustCall
8c8b123 
remove process.on('exit') because all callbacks are
wrapped by common.mustCall.

PR-URL: #9959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
italoacasas mentioned this pull request Dec 17, 2016
Merged
cjihrig pushed a commit that referenced this pull request Dec 20, 2016
test: use const/let and common.mustCall
48b45ff 
remove process.on('exit') because all callbacks are
wrapped by common.mustCall.

PR-URL: #9959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
targos pushed a commit that referenced this pull request Dec 26, 2016
test: use const/let and common.mustCall
bdf633a 
remove process.on('exit') because all callbacks are
wrapped by common.mustCall.

PR-URL: #9959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins mentioned this pull request Dec 27, 2016
Merged
targos pushed a commit that referenced this pull request Dec 28, 2016
test: use const/let and common.mustCall
1acb95d 
remove process.on('exit') because all callbacks are
wrapped by common.mustCall.

PR-URL: #9959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
test: use const/let and common.mustCall
494d236 
remove process.on('exit') because all callbacks are
wrapped by common.mustCall.

PR-URL: #9959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
test: use const/let and common.mustCall
50cde14 
remove process.on('exit') because all callbacks are
wrapped by common.mustCall.

PR-URL: #9959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins mentioned this pull request Jan 24, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
test: use const/let and common.mustCall
fc67a95 
remove process.on('exit') because all callbacks are
wrapped by common.mustCall.

PR-URL: #9959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
+2 more reviewers
princejwesley princejwesley left review comments
silverwind silverwind approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL