FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Change var to const or let in test-child-process-ipc.js by malenesok007 · Pull Request #9990 · nodejs/node · GitHub

/ node Public

Change var to const or let in test-child-process-ipc.js - #9990

Closed
malenesok007 wants to merge 1 commit into
nodejs:masterfrom
malenesok007:myChanges
ConversationCommits (1)ChecksFiles changed
Closed

Change var to const or let in test-child-process-ipc.js#9990
malenesok007 wants to merge 1 commit into
nodejs:masterfrom
malenesok007:myChanges

Conversation

malenesok007 commented Dec 1, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016

imyller commented Dec 1, 2016

Copy link
Copy Markdown
Member

@malenesok007 May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines.

mscdex added the child_process Issues and PRs related to the child_process subsystem. label Dec 1, 2016

malenesok007 commented Dec 1, 2016

Copy link
Copy Markdown
Contributor Author

Hi I have modify the commit message. Is there something I am missing? Thanks.

cjihrig approved these changes Dec 5, 2016
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM pending CI.

Trott commented Dec 8, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5326/

silverwind suggested changes Dec 9, 2016
View reviewed changes
Comment thread test/parallel/test-child-process-ipc.js Outdated

silverwind Dec 9, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Linter error here:

 error  'child' is never reassigned. Use 'const' instead  prefer-const

Trott commented Dec 22, 2016

Copy link
Copy Markdown
Member

Ping @malenesok007: Can you change the let to const as identified in the comment from @silverwind? You can run make jslint (or, if on Windows, vcbuild jslint nosign I think) to check for other lint errors before pushing.

Trott commented Dec 24, 2016

Copy link
Copy Markdown
Member

Because it was a straightforward lint fix, I made the change and pushed it to @malenesok007's branch.

@silverwind Can you take a look and, if appropriate, update your review? Thanks!

Trott commented Dec 24, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5568/

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 24, 2016
test: refactor test-child-process-ipc
ff88a5a 
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: nodejs#9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

Trott commented Dec 24, 2016

Copy link
Copy Markdown
Member

Landed in ff88a5a.
Thanks for the contribution! 🎉

Trott closed this Dec 24, 2016
targos pushed a commit that referenced this pull request Dec 26, 2016
test: refactor test-child-process-ipc
610ec55 
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: #9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins mentioned this pull request Dec 27, 2016
Merged
targos pushed a commit that referenced this pull request Dec 28, 2016
test: refactor test-child-process-ipc
16460e9 
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: #9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
evanlucas mentioned this pull request Jan 3, 2017
Merged
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
test: refactor test-child-process-ipc
c2b525a 
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: #9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
test: refactor test-child-process-ipc
599a2a9 
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: #9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
test: refactor test-child-process-ipc
c074982 
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: #9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
test: refactor test-child-process-ipc
3ffd4d6 
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: #9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins mentioned this pull request Jan 24, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
test: refactor test-child-process-ipc
4efdbaf 
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: #9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
silverwind silverwind approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

child_process Issues and PRs related to the child_process subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL