src: remove duplicate buffer info calls - #1354
Merged
legendecas merged 1 commit intoJul 27, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The constructor of the Uint8Array has called napi_get_typed_array_info, which should be identical to napi_get_buffer_info. Remove the duplicated napi_get_buffer_info call.
legendecas
marked this pull request as ready for review
July 21, 2023 15:09
mhdawson
approved these changes
Jul 21, 2023
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
KevinEady
approved these changes
Jul 24, 2023
KevinEady
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constructor of the Uint8Array has called napi_get_typed_array_info,
which should be identical to napi_get_buffer_info. Remove the duplicated
napi_get_buffer_info call.
Refs: nodejs/node#48742