add skipFiles override by default for VSCode - #14
Open
Ethan-Arrowood wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
trivikr
approved these changes
Nov 7, 2024
legendecas
reviewed
Jan 15, 2025
Comment thread
.vscode/launch.json
| "runtimeExecutable": "${workspaceFolder}/node" | ||
| "runtimeExecutable": "${workspaceFolder}/node", | ||
| "skipFiles": [ | ||
| // VSCode excludes node internals by default. Uncomment this to include them. |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I don't think vscode skips <node_internals> by default. The document also suggests that the config has to be manually added: https://code.visualstudio.com/docs/nodejs/nodejs-debugging#_additional-configuration
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As titled. This change will enable debugging node internals by default which for core makes the most sense. Includes a comment for folks to understand how to disable that if they want the original behavior.