feat(v8): add llvm-libc to V8 deps - #1073
Merged
targos merged 1 commit intoMay 13, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Keep only the folders that are needed at the moment Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7828379
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1073 +/- ##
=======================================
Coverage 71.78% 71.78%
=======================================
Files 41 41
Lines 5887 5887
=======================================
Hits 4226 4226
Misses 1661 1661 ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
From the POV of keeping canary green, LGTM, but this implies we are going to statically compile some part of llvm-libc in? Is that going to work on e.g. macOS? |
Sorry, something went wrong.
joyeecheung
approved these changes
May 12, 2026
Copy link
Copy Markdown
Member
Author
|
I tested it on my macOS machine, but I don't really understand the implications. |
Sorry, something went wrong.
richardlau
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selectively keep only the folders that are needed at the moment
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7828379
I tested a canary update locally and this fixes the build.