fix: collect all PR-URL entries in getAltPrUrl() - #1090
Open
watilde wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1090 +/- ##
==========================================
+ Coverage 64.93% 65.13% +0.20%
==========================================
Files 45 45
Lines 6938 6939 +1
==========================================
+ Hits 4505 4520 +15
+ Misses 2433 2419 -14 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getAltPrUrl() was only ever returning the first PR-URL entry in a commit message body. The root cause was PR_RE missing the global flag (g), so text.match(PR_RE) returned a single match-result array (full match + capture group) instead of an array of all matching lines.
This follows the existing pattern in the file where FIXES_RE/FIX_RE and REFS_RE/REF_RE are paired as global/non-global variants. Added PRS_RE as the global counterpart and updated getAltPrUrl() to use it.