FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: use `getUrlFromOP()` for `fixes` links by richardlau · Pull Request #614 · nodejs/node-core-utils · GitHub

/ node-core-utils Public

fix: use getUrlFromOP() for fixes links - #614

Merged
targos merged 1 commit into
nodejs:mainfrom
richardlau:fixfixfix
Apr 19, 2022
ConversationCommits (1)ChecksFiles changed
Merged

fix: use getUrlFromOP() for fixes links#614
targos merged 1 commit into
nodejs:mainfrom
richardlau:fixfixfix

Conversation

richardlau commented Mar 19, 2022

Copy link
Copy Markdown
Member

When parsing fixes links, use the same code that is used for parsing
the refs and PR-URL links. This avoids the manual URL construction
that was inserting bad links into the metadata for the npm update pull
requests.

Refs: nodejs/node#42382 (comment)

This is an alternative to #612 which also fixes the case in #612 (comment).

fix: use getUrlFromOP() for fixes links
53582bd 
When parsing `fixes` links, use the same code that is used for parsing
the `refs` and `PR-URL` links. This avoids the manual URL construction
that was inserting bad links into the metadata for the npm update pull
requests.

codecov Bot commented Mar 19, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #614 (53582bd) into main (5e85166) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
- Coverage   84.10%   84.09%   -0.01%     
==========================================
  Files          37       37              
  Lines        4051     4049       -2     
==========================================
- Hits         3407     3405       -2     
  Misses        644      644
Impacted Files Coverage Δ
lib/links.js 91.86% <100.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e85166...53582bd. Read the comment docs.

richardlau mentioned this pull request Mar 19, 2022
Closed
richardlau commented Mar 19, 2022
View reviewed changes
Comment thread test/unit/links.test.js
mhdawson approved these changes Mar 23, 2022
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

richardlau commented Apr 1, 2022

Copy link
Copy Markdown
Member Author

Anyone have any ideas about the coverage drop/failure? Are we able to land with this check failing?

FWIW TIL that npx node-core-utils runs the equivalent of git node metadata. For nodejs/node#42550:

$ npx node-core-utils 42550
npx: installed 493 in 17.679s
✔  Done loading data for nodejs/node/pull/42550
----------------------------------- PR info ------------------------------------
Title      deps: upgrade npm to 8.6.0 (#42550)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     npm-robot:npm-8.6.0 -> nodejs:master
Labels     npm, fast-track, needs-ci, dont-land-on-v12.x, dont-land-on-v14.x
Commits    1
 - deps: upgrade npm to 8.6.0
Committers 1
 - npm team <ops+robot@npmjs.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42550
Fixes: https://github.com/remove
Fixes: https://github.com/100%
Fixes: https://github.com/make
Fixes: https://github.com/move
Fixes: https://github.com/really
Fixes: https://github.com/consolidate
Fixes: https://github.com/consolidate
Fixes: https://github.com/consolidate
Fixes: https://github.com/consolidate
Fixes: https://github.com/bump
Fixes: https://github.com/return
Fixes: https://github.com/consolidate
Fixes: https://github.com/work
Fixes: https://github.com/only
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 31 Mar 2022 22:43:19 GMT
   ✔  Approvals: 4
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/42550#pullrequestreview-928307710
   ✔  - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42550#pullrequestreview-928452353
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/42550#pullrequestreview-928474922
   ✔  - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/42550#pullrequestreview-928474971
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-04-01T08:44:02Z: https://ci.nodejs.org/job/node-test-pull-request/43255/
✔  Build data downloaded
   ✔  Last Jenkins CI successful

while with this PR:

$ node bin/get-metadata.js 42550
✔  Done loading data for nodejs/node/pull/42550
----------------------------------- PR info ------------------------------------
Title      deps: upgrade npm to 8.6.0 (#42550)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     npm-robot:npm-8.6.0 -> nodejs:master
Labels     npm, fast-track, needs-ci, dont-land-on-v12.x, dont-land-on-v14.x
Commits    1
 - deps: upgrade npm to 8.6.0
Committers 1
 - npm team <ops+robot@npmjs.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42550
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 31 Mar 2022 22:43:19 GMT
   ✔  Approvals: 4
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/42550#pullrequestreview-928307710
   ✔  - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42550#pullrequestreview-928452353
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/42550#pullrequestreview-928474922
   ✔  - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/42550#pullrequestreview-928474971
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-04-01T08:44:02Z: https://ci.nodejs.org/job/node-test-pull-request/43255/
✔  Build data downloaded
   ✔  Last Jenkins CI successful


      		
    

  





        

            

            

              
            

        

      


      
            
  
  

    
  
  

  

  

    












      

  
          

  

    
  


  

      


    
richardlau



    mentioned this pull request
    
      Apr 1, 2022
    





  


  

      
   Closed

  







  









      

  
      



  

  






  



    

      

  

    

      
          
      

      
            targos
    

      

      

      commented


        Apr 19, 2022



      
    


  


  

    

      
          
    
  


        
            
  
      
              Copy link

  

            
  
      
              Copy Markdown

  

        
      
    


    

        

  
  Member


        

    

  





      


        



  
    

      
          


Are we able to land with this check failing?




Yes. I'll land.


      		
    

  





        

            

            

              
            

        

      


      
            
  
  

    
  
  

  

  

    












      

  
          
 
  

    
  

  



    

        

              


        

      

              targos



            merged commit 4b0e94b
          into

          
  
    nodejs:main
  


        Apr 19, 2022

      

    


  







  

  

    
  


  

      


    
github-actions
Bot


    mentioned this pull request
    
      Apr 19, 2022
    





  


  

      
   Merged

  







  




  

  
  

  
    

        

              


        

      

            richardlau


        
    deleted the
    
      
        fixfixfix
    
    branch

        April 19, 2022 16:22        
        
      

    














  
  

    
      
  










  




  

  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    


  
            Show hidden characters






  
    




  
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  










    
        

  
    
    

    

  

    Reviewers
  


    


      

  

    


  
      
  
    ruyadorno



    
      
        
      
    
    ruyadorno approved these changes




      
        
          +1 more reviewer
          
          
        
          

            

  

    


  
      
  
    mhdawson



    
      
        
      
    
    mhdawson approved these changes



          

      
      Reviewers whose approvals may not affect merge requirements

      







  
      

  

      
  

    Assignees
  



        


    No one assigned







  
        


  


  

    Labels
  



    

    None yet







  
        

  

    
        

    Projects
  


        




    None yet



  



  
        


  
    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        
          
  

    Development
  



            


Successfully merging this pull request may close these issues.





  
  


      
    

  




      

  
  
        

  

    

      4 participants
    

    

        
           
        
           
        
           
        
           
    

  





  
  
  
  
  
  









  




        











  
  Back | 
  FazBrowse Home |
  New Git URL