FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: increase test timeouts to avoid flaky tests by tniessen · Pull Request #622 · nodejs/node-core-utils · GitHub

chore: increase test timeouts to avoid flaky tests - #622

Merged
tniessen merged 1 commit into
nodejs:mainfrom
tniessen:short-timeouts-are-useless
Apr 22, 2022
Merged

chore: increase test timeouts to avoid flaky tests#622
tniessen merged 1 commit into
nodejs:mainfrom
tniessen:short-timeouts-are-useless

Conversation

Copy link
Copy Markdown
Member

mocha defaults to a 2000ms timeout, which frequently causes CI to fail.
Since such short timeouts are pretty much useless, vastly increase the
timeout to one minute per test.

tniessen added the test Issues related to test suites label Apr 21, 2022

codecov Bot commented Apr 21, 2022
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #622 (e7fd056) into main (649a3b0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #622   +/-   ##
=======================================
  Coverage   84.13%   84.13%           
=======================================
  Files          37       37           
  Lines        4065     4065           
=======================================
  Hits         3420     3420           
  Misses        645      645           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 649a3b0...e7fd056. Read the comment docs.

mocha defaults to a 2000ms timeout, which frequently causes CI to fail.
Since such short timeouts are pretty much useless, vastly increase the
timeout to one minute per test.
tniessen force-pushed the short-timeouts-are-useless branch from f146809 to e7fd056 Compare April 21, 2022 23:34
tniessen changed the title Increase test timeouts to avoid flaky tests chore: increase test timeouts to avoid flaky tests Apr 22, 2022
tniessen merged commit e798b77 into nodejs:main Apr 22, 2022
tniessen deleted the short-timeouts-are-useless branch April 22, 2022 22:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues related to test suites

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL