FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore!: remove unmarked DEP0XXX handler by aduh95 · Pull Request #685 · nodejs/node-core-utils · GitHub

chore!: remove unmarked DEP0XXX handler - #685

Merged
aduh95 merged 2 commits into
nodejs:mainfrom
aduh95:DEP0XXX
Sep 24, 2023
Merged

chore!: remove unmarked DEP0XXX handler#685
aduh95 merged 2 commits into
nodejs:mainfrom
aduh95:DEP0XXX

Conversation

aduh95 commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

The deprecation numbers are linted by the test-doc test suite, and using DEP0XXX would be flagged as invalid before the PR can land.

The deprecation numbers are linted by the `test-doc` test suite, and
using `DEP0XXX` would be flagged as invalid before the PR can land.

codecov Bot commented Mar 8, 2023
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (4c2d84e) 83.38% compared to head (0f46464) 83.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #685   +/-   ##
=======================================
  Coverage   83.38%   83.38%           
=======================================
  Files          37       37           
  Lines        4158     4158           
=======================================
  Hits         3467     3467           
  Misses        691      691           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

The deprecation numbers are linted by the test-doc test suite, and using DEP0XXX would be flagged as invalid before the PR can land.

Is that true on all supported release lines?

aduh95 commented Mar 8, 2023

Copy link
Copy Markdown
Contributor Author

The deprecation numbers are linted by the test-doc test suite, and using DEP0XXX would be flagged as invalid before the PR can land.

Is that true on all supported release lines?

It seems that nodejs/node#41992 hasn't been backported to v14.x, so I guess this should wait for v14.x to be officially EOL.

Copy link
Copy Markdown
Member

The deprecation numbers are linted by the test-doc test suite, and using DEP0XXX would be flagged as invalid before the PR can land.

Is that true on all supported release lines?

It seems that nodejs/node#41992 hasn't been backported to v14.x, so I guess this should wait for v14.x to be officially EOL.

Thank you for checking. I suspect it's highly unlikely we'll deprecate something new in Node.js 14 before it reaches End-of-Life. I'd be okay landing if other @nodejs/releasers agree, otherwise we can wait.

targos commented Mar 8, 2023

Copy link
Copy Markdown
Member

SGTM

juanarbol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

targos commented Apr 17, 2023

Copy link
Copy Markdown
Member

@aduh95 there's a conflict now.

aduh95 changed the title chore: remove unmarked DEP0XXX handler chore!: remove unmarked DEP0XXX handler Apr 17, 2023
aduh95 merged commit bdb85a9 into nodejs:main Sep 24, 2023
aduh95 deleted the DEP0XXX branch September 24, 2023 09:13
This was referenced Sep 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL