FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add support for nvm by UlisesGascon · Pull Request #759 · nodejs/node-core-utils · GitHub

feat: add support for nvm - #759

Open
UlisesGascon wants to merge 1 commit into
nodejs:mainfrom
UlisesGascon:feat/add-nvm-support
Open

feat: add support for nvm#759
UlisesGascon wants to merge 1 commit into
nodejs:mainfrom
UlisesGascon:feat/add-nvm-support

Conversation

Copy link
Copy Markdown
Member

No description provided.

targos commented Dec 4, 2023

Copy link
Copy Markdown
Member

Not sure what's the point? We want the utils to work on all supported versions, so I think it's good if we have a variety of versions used by collaborators.

UlisesGascon commented Dec 20, 2023
edited
Loading

Copy link
Copy Markdown
Member Author

Not sure what's the point? We want the utils to work on all supported versions, so I think it's good if we have a variety of versions used by collaborators.

I think that is important to use minimum compatible version when developing the library so we prevent to introduce bugs. For example using Node@20 features that are not available in 18.18.0.

The collaborators can use a variety of version defined by the engine https://github.com/nodejs/node-core-utils/blob/main/package.json#L7 independently 👍

targos commented Dec 21, 2023

Copy link
Copy Markdown
Member

Ok, I won't block it but I don't use nvm so I'll let someone else review. Please if it lands, don't use feat: (or fix:) in the commit message, as this change doesn't impact users who install the package AFAIK.

Copy link
Copy Markdown
Member

For example using Node@20 features that are not available in 18.18.0.

That should be checked by the CI instead, I believe. The config won't do much for contributors to this repo who don't use nvm, then they won't catch it anyway...

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL