feat(ncu-ci)!: require --certify-safe flag - #798
Merged
aduh95 merged 3 commits intoApr 24, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Or ensure the PR has received at least one approving review since last time it was pushed.
anonrig
reviewed
Apr 24, 2024
mcollina
approved these changes
Apr 24, 2024
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
anonrig
approved these changes
Apr 24, 2024
benjamingr
approved these changes
Apr 24, 2024
MoLow
approved these changes
Apr 24, 2024
BridgeAR
approved these changes
Apr 24, 2024
BridgeAR
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
RSLGTM
Sorry, something went wrong.
MoLow
approved these changes
Apr 24, 2024
Copy link
Copy Markdown
Member
|
This is currently a bit too restrictive - it should add an exceptions to collaborators otherwise even a collaborator cannot use the label to run the CI wihout an approving review (or after they've pushed a new commit), see nodejs/node#52692 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@aduh95 do you intend to make a patch based on what @joyeecheung mentioned? 👀 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Or ensure the PR has received at least one approving review since last time it was pushed.