feat(ncu-ci): check for request-ci label - #806
Conversation
Sorry, something went wrong.
When running `ncu-ci` without the `--certify-safe` CLI flag, if something was pushed to a PR since the last approving review, check if the last time the `request-ci` label was added, it was done by a Collaborator and after the last push event on the PR.
fix for when there are no request-ci labels
MoLow
left a comment
There was a problem hiding this comment.
LGTM. can you add tests?
Sorry, something went wrong.
Tests would be great, I'd prefer if someone else could contribute that, I'm not sure when I'd have time to work on that |
Sorry, something went wrong.
| ]); | ||
| } | ||
|
|
||
| async getLabels() { |
This comment was marked as resolved.
| async checkCommitsAfterReviewOrLabel() { | ||
| if (this.checkCommitsAfterReview()) return true; | ||
|
|
||
| await Promise.all([this.data.getLabels(), this.data.getCollaborators()]); |
This comment was marked as resolved.
There was a problem hiding this comment.
How would that change the testability? Making extra requests will make it more likely that the bot will reach its quota of requests and be rate limited, making the requests lazilly seems like a low-hanging fruit.
Sorry, something went wrong.
This comment was marked as resolved.
|
I created a PR against this branch on your fork (aduh95#1) 🙂 |
Sorry, something went wrong.
|
/cc @nodejs/node-core-utils |
Sorry, something went wrong.
This reverts commit 6cc2b1a.
This reverts commit 6cc2b1a.
When commits were pushed to a PR since the last approving review, check if the last time a request-ci label was added, it was done by a Collaborator and after the last push event on the PR.
I don't really like the fact "request-ci" is hard-coded, and also it might make sense to enable this check only in the GHA workflow (as the code doesn't search for 'unlabeled' events, so if someone adds the label and removes it, it would still still count), so if you have suggestions regarding that, I'd be interested.
Fixes: #801