| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
yes, only people with write access have the ability to edit comments |
Sorry, something went wrong.
|
Would you like a review before updating the tests? |
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #920 +/- ##
==========================================
+ Coverage 79.70% 79.82% +0.12%
==========================================
Files 39 39
Lines 4642 4650 +8
==========================================
+ Hits 3700 3712 +12
+ Misses 942 938 -4 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
There was a problem hiding this comment.
AFAICT, this allows to request CI for a commit SHA that is not part of the pull request. Is that a bug or a feature?
Sorry, something went wrong.
The commit SHA provided by the collaborator with be passed as COMMIT_SHA_CHECK , Jenkins checks that GIT_REMOTE_REF (i.e. refs/pull/${prID}/head) resolves to that expected commit SHA, otherwise the CI fails. So if someone pass the SHA of a commit not in the PR branch, it won't match the tip of the PR head, and it won't work |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Currently, the request-ci only works for approved PRs. This is annoying because:
There have been suggestions to use PR author, or PR head repo owner, or commit signature, or a combination of the three – but I don't really like that idea, because:
IIUC comments are not editable by triagers, so should be a safe way to determine a safe SHA for unapproved PRs.
EDIT 2026: it is annoying, but also seems to be mostly working, folks have gotten used to wait for approval or start CI manually. Not sure this is actually needed.