fix: prepare interfaces updater for updated webcrypto - #927
Merged
aduh95 merged 1 commit intoMay 22, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #927 +/- ##
=======================================
Coverage 79.76% 79.76%
=======================================
Files 39 39
Lines 4630 4630
=======================================
Hits 3693 3693
Misses 937 937 ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
targos
approved these changes
May 5, 2025
Copy link
Copy Markdown
Member
Author
|
Can we merge and release this? Future WPT updates to interfaces and webcrypto are blocked at the moment. nodejs/node#58176 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds webcrypto to the list of known interfaces to pull since web-platform-tests/wpt#52264 makes it so the file no longer matches the directory name in webcrypto's case.