test: fix undici 8.7.0 compatibility - #3345
Merged
legendecas merged 2 commits intoJul 14, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This was referenced Jul 9, 2026
cclauss
reviewed
Jul 9, 2026
Comment thread
.github/workflows/visual-studio.yml
| @@ -24,6 +24,7 @@ jobs: | |||
| - os: windows-11-arm | |||
| msvs-version: 2022 # Fix this when Visual Studio 2025 is released | |||
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Customers needing Visual Studio 2022 must migrate to the windows-2022 image.
https://github.com/actions/runner-images/tree/main/images/windows
https://github.com/actions/runner-images/tree/main#available-images
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
windows-11-arm is still vs 2022: https://github.com/actions/runner-images/blob/main/images/windows/Windows11-Arm64-Readme.md#visual-studio-enterprise-2022
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@cclauss would you mind taking a look? thanks! |
Sorry, something went wrong.
cclauss
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Previously undici ProxyAgent/EnvHttpProxyAgent tunneled all proxied requests via CONNECT. As of nodejs/undici#5116 (v8.7.0), plain HTTP requests are forwarded to the proxy in absolute-form (a normal request), and only HTTPS still uses a CONNECT tunnel. The node-gyp test proxy only listened for the connect event, so the forwarded HTTP request got no response and the test hung to the 30s timeout.