FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix install: add iojs support by coderaiser · Pull Request #669 · nodejs/node-gyp · GitHub

  1. nodejs
  2. node-gyp

Repository navigation

fix install: add iojs support - #669

Closed
coderaiser wants to merge 1 commit into
nodejs:masterfrom
coderaiser:patch-2
ConversationCommits (1)ChecksFiles changed
Closed

fix install: add iojs support#669
coderaiser wants to merge 1 commit into
nodejs:masterfrom
coderaiser:patch-2

Conversation

coderaiser commented Jul 20, 2015

Copy link
Copy Markdown

Add iojs support: when version >=1.0.0 download dist from url https://iojs.org.

gyp WARN install got an error, rolling back install
gyp ERR! configure error
gyp ERR! stack Error: 404 response downloading https://nodejs.org/dist/v2.4.0/node-v2.4.0.tar.gz
gyp ERR! stack     at Request.<anonymous> (/home/coderaiser/.nvm/versions/io.js/v2.4.0/lib/node_modules/npm/node_modules/node-gyp/lib/install.js:251:14)
gyp ERR! stack     at emitOne (events.js:82:20)
gyp ERR! stack     at Request.emit (events.js:169:7)
gyp ERR! stack     at Request.onRequestResponse (/home/coderaiser/.nvm/versions/io.js/v2.4.0/lib/node_modules/npm/node_modules/request/request.js:985:10)
gyp ERR! stack     at emitOne (events.js:77:13)
gyp ERR! stack     at ClientRequest.emit (events.js:169:7)
gyp ERR! stack     at HTTPParser.parserOnIncomingClient (_http_client.js:415:21)
gyp ERR! stack     at HTTPParser.parserOnHeadersComplete (_http_common.js:88:23)
gyp ERR! stack     at TLSSocket.socketOnData (_http_client.js:305:20)
gyp ERR! stack     at emitOne (events.js:77:13)

This was referenced Jul 20, 2015
Closed
Closed

gabeio commented Jul 20, 2015

Copy link
Copy Markdown

👍 though also fixed in #564 ...

thomasjo mentioned this pull request Jul 29, 2015
Merged
20 tasks done

iamstarkov commented Aug 5, 2015

Copy link
Copy Markdown

I think node-gyp is broken also with iojs@3.0, @gabeio @coderaiser can you take a look here paulmillr/chokidar#329?

gabeio commented Aug 5, 2015

Copy link
Copy Markdown

@iamstarkov I am having build issues with iojs 3 also... but sidenote you may be able to build it with 2.5.0 or lower and still use the package in 3.0.0 nevermind you can't 😢

camsong reviewed Aug 9, 2015
View reviewed changes
Comment thread lib/install.js

camsong Aug 9, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This may not reliable if NodeJS released v1.0.0 someday, I prefer process.release.node === 'io.js'.

Fishrock123 Aug 22, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

"Node.js" 1.0.0 will never be released. As a TSC member, I can authoritatively say that. :)

Also, io.js is node.js now: https://github.com/nodejs/node

However, version detection still isn't a great way of doing things, though it could for for io.js 1.0.0> <3.0.0. As @camsong said, what we really should be doing now is detecting 3.0.0's process.release :)

camsong mentioned this pull request Aug 9, 2015
Closed
Fishrock123 mentioned this pull request Aug 23, 2015
Closed

justinmchase commented Aug 23, 2015

Copy link
Copy Markdown

As a workaround, you can build against electron and end up with binaries that also load into vanilla iojs:

$ npm install electron-prebuilt -g
$ npm install electron-updater-tools -g
$ elb configure

The last command runs a script in the electron-updater-tools project that uses a --dist-url for electron that is compatible with node-gyp. It uses a delay load hack to make the binaries compatible with electron and iojs/node.

I ideally this would be fixed in node-gyp directly. Also related to this PR: #653

rgbkrk commented Aug 24, 2015

Copy link
Copy Markdown

Nice @justinmchase!

TooTallNate commented Sep 28, 2015

Copy link
Copy Markdown
Contributor

Superseded by #711.

Koroffin pushed a commit to Koroffin/node-gyp that referenced this pull request Sep 8, 2025
fix: comment out invalid API call (nodejs#669)
2dab380
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

io.js

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL