FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: run sync-api for 18.9.0 docs by nschonni · Pull Request #2759 · nodejs/nodejs.dev · GitHub

This repository was archived by the owner on Apr 26, 2024. It is now read-only.
/ nodejs.dev Public archive

chore: run sync-api for 18.9.0 docs - #2759

Merged
ovflowd merged 1 commit into
nodejs:mainfrom
nschonni:18.9.0
Sep 12, 2022
ConversationCommits (1)ChecksFiles changed
Merged

chore: run sync-api for 18.9.0 docs#2759
ovflowd merged 1 commit into
nodejs:mainfrom
nschonni:18.9.0

Conversation

nschonni commented Sep 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Just run npm run sync-api and doesn't make any other changes

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run lint:js -- --fix and/or npm run lint:md -- --fix for my JavaScript and/or Markdown changes.
    • This is important as most of the cases your code changes might not be correctly linted
  • I have run npm run test to check if all tests are passing, and/or npm run test -- -u to update snapshots if I created and/or updated React Components.
  • I have checked that the build works locally and that npm run build work fine.
  • I've covered new added functionality with unit tests if necessary.

nschonni mentioned this pull request Sep 12, 2022
Merged
5 tasks
nschonni commented Sep 12, 2022
View reviewed changes
Comment thread content/api/v18/addons.en.md
displayTitle: 'C++ addons'
category: 'api'
editPage: 'https://github.com/nodejs/node/blob/v18.8.0/doc/api/addons.md'
editPage: 'https://github.com/nodejs/node/blob/v18.9.0/doc/api/addons.md'

nschonni Sep 12, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Aside, this could probable be guess/calculated at build time to reduce git noise

nschonni Sep 12, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Also missing the i18n part of the file path right now

ovflowd Sep 12, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Also missing the i18n part of the file path right now

WDYM? The source has no i18n. The i18n is done here.

ovflowd Sep 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Aside, this could probable be guess/calculated at build time to reduce git noise

Sure, but this PR is not the right place (IMHO) to talk about this. I'd recommend opening an issue with all your suggestions.

nschonni Sep 12, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh, I see it's on the node repo. The URL doesn't actually take you to an editable page though, because you can't edit files on a tag path

nschonni requested a review from ovflowd September 12, 2022 21:41
ovflowd approved these changes Sep 12, 2022
View reviewed changes

ovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think I understand the point of this PR now. Let's merge this ASAP as it's just a dry-run

ovflowd merged commit a4160b8 into nodejs:main Sep 12, 2022
nschonni deleted the 18.9.0 branch September 12, 2022 22:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
ovflowd ovflowd approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL