| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
This list is very incomplete. Higher-impact dependencies such as undici and nghttp2 are not listed either. I am not sure what subset of dependencies makes sense here, or if this page provides value at all in its current state.
Sorry, something went wrong.
|
@tniessen the page is just super outdated. But would love if it can be updated with all the new stuff :D |
Sorry, something went wrong.
|
I'm not sure this page adds value for the average user. I wonder if it should be ported to a README for the deps directory in Node.js source. Then we can replace the page with a link there. That is far more likely to be updated when people add/remove dependencies. And because the README is associated with a particular commit, it will reflect the status at that commit. In other words, we avoid the problem of trying to write a single page that reflects all versions of Node.js. |
Sorry, something went wrong.
None of this is an objection to updating the page to reflect current-ish information though. |
Sorry, something went wrong.
|
That's correct, @Trott. We can close this PR and pivot to doing something on node/deps/README.md. I mention this because I remembered the nodejs.dev "about" doesn't mention any of these dependencies. Meaning even if we add this now, as we agreed that the .dev pages replace the .org ones, it will be removed very prematurely. @anonrig do you think you can pivot such kind of change on @nodejs/node/deps/README.md? |
Sorry, something went wrong.
Co-authored-by: Rich Trott <rtrott@gmail.com> Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
Co-authored-by: Rich Trott <rtrott@gmail.com> Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
@Trott Even though, I agree with your concerns, this particular recommendation will lead to outdated commit URL in this page too. If we are going this path, I think we should include the dependencies and distribute it with the Node.js documentation (which is version specific). (I didn't had any chance to look into the documentation tools & infrastructure. I don't know the depth or possibility of this task, therefore my assumption/recommendation might be invalid.)
@Trott I recommend merging this pull request, and later discuss the future of this document in a separate PR or an issue for wider visibility.
@ovflowd If this is the case, we should remove those documents from Crowdin. A lot of people are investing their own time to translate these soon-to-be-removed documents, and if we are simply not use them in the future, we should suspend all translation activities.
@ovflowd As a non-native English speaker, I think there are more qualified people who can do this faster & cleaner than me. |
Sorry, something went wrong.
|
@anonrig Ive made an announcement on Crowdin several days ago asking people to no translate the current content as it's going to be 100% discarded 🙈 |
Sorry, something went wrong.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Sorry, something went wrong.
I'd be happy to draft this up! |
Sorry, something went wrong.
|
I was about to propose a new README at deps/README.md, but a quick scan of the current codebase found an existing and probably better source: doc/contributing/maintaining/maintaining-dependencies Taking @Trott's words here as a guiding set of principles, this file seems to have everything we would want:
tl;dr: merge this as discused previously, but eventually shift toward linking directly to https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-dependencies.md#dependency-list or https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-dependencies.md |
Sorry, something went wrong.
|
I think we should delete this page and make the link on navigation to simply redirect to the Markdown file on core. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
The current dependencies list is not up to date. The following changes only updates Ada, Node.js's new URL parser.