chore(remark-lint): improve for node core by avivkeller · Pull Request #9016 · nodejs/nodejs.org · GitHub

Improves the remark-lint package by:

Fixing an issue with type validation where it would include comments, code blocks, etc
Adding link validation, as mentioned by @aduh95

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
nodejs-org	Ready	Preview	Jul 26, 2026 9:56pm

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

PR Summary

Low Risk
Changes are limited to lint tooling, docs/content link fixes, and a targeted rule scope fix; no runtime or auth behavior is affected.

Overview
Adds a node-core:validate-links remark rule that checks root-relative and relative links resolve to site content (extension-less routes, index.*, public assets) and that same-page # fragments match headings or custom HTML id/name anchors. The rule is wired into the default @node-core/remark-lint preset and enabled for the site via .remarkrc.json, with globs skipping non-English pages and ignoring /learn, /static, and /feed paths until translations catch up.

invalid-type-reference now only runs on prose text/html nodes so {...} inside comments, fenced code, and JSX is no longer flagged; tests cover that behavior.

English content is updated to satisfy the new checks (release schedule path, N-API learn URL, branding link, security-policy footers, a missing leading / on a blog link, and legacy internal links replaced with GitHub URLs where pages no longer exist).

Reviewed by Cursor Bugbot for commit 6310f15. Bugbot is set up for automated code reviews on this repo. Configure here.

Codecov Report

❌ Patch coverage is 91.86992% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.14%. Comparing base (0492dea) to head (6310f15).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
packages/remark-lint/src/rules/validate-links.mjs	89.84%	20 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9016      +/-   ##
==========================================
+ Coverage   74.55%   75.14%   +0.59%     
==========================================
  Files         100      102       +2     
  Lines        8823     9109     +286     
  Branches      324      372      +48     
==========================================
+ Hits         6578     6845     +267     
- Misses       2241     2260      +19     
  Partials        4        4

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

📦 Build Size Comparison

Summary

Metric	Value
Old Total First Load JS	10.65 MB
New Total First Load JS	10.65 MB
Delta	0 B (0.00%)

Bump @nodejs/web-infra

there's a cursor concern here Link validator lacks needed options that is perhaps valid. can you validate the real runtime scenarios here? it'd be bad if this resulted in false-positivies

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Replaced remark-validate-links with our own validator to allow for:

Node.js-style slugs
Path exclusions

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e244251. Configure here.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

avivkeller requested review from a team as code owners July 21, 2026 03:35

Copilot AI review requested due to automatic review settings July 21, 2026 03:35

Copilot AI reviewed Jul 21, 2026

vercel Bot deployed to Preview July 21, 2026 03:36 View deployment

vercel Bot deployed to Preview July 21, 2026 03:39 View deployment

cursor Bot reviewed Jul 21, 2026

View reviewed changes

Comment thread packages/remark-lint/src/index.mjs Outdated

bjohansebas approved these changes Jul 21, 2026

View reviewed changes

bmuenzenmeyer reviewed Jul 24, 2026

View reviewed changes

Comment thread packages/remark-lint/src/__tests__/index.test.mjs Outdated

Copilot AI review requested due to automatic review settings July 25, 2026 22:25

avivkeller requested a review from a team as a code owner July 25, 2026 22:25

avivkeller requested a review from bmuenzenmeyer July 25, 2026 22:25

Copilot AI reviewed Jul 25, 2026

vercel Bot deployed to Preview July 25, 2026 22:25 View deployment

Copilot AI review requested due to automatic review settings July 25, 2026 22:26

Copilot AI reviewed Jul 25, 2026

vercel Bot deployed to Preview July 25, 2026 22:27 View deployment

cursor Bot reviewed Jul 25, 2026

View reviewed changes

Comment thread packages/remark-lint/package.json

Copilot AI review requested due to automatic review settings July 26, 2026 02:11

Copilot AI reviewed Jul 26, 2026

vercel Bot deployed to Preview July 26, 2026 02:12 View deployment

cursor Bot reviewed Jul 26, 2026

View reviewed changes

Comment thread apps/site/.remarkrc.json

bjohansebas approved these changes Jul 26, 2026

View reviewed changes

chore(remark-lint): improve for node core

6718243

avivkeller added 4 commits July 26, 2026 13:37

fixup!

d3c98eb

fixup!

27d20cd

fixup!

89f0699

fixup!

6310f15

Copilot AI review requested due to automatic review settings July 26, 2026 21:55

avivkeller force-pushed the remark-lint-changes branch from e244251 to 6310f15 Compare July 26, 2026 21:55

Copilot AI reviewed Jul 26, 2026

vercel Bot deployed to Preview July 26, 2026 21:56 View deployment

avivkeller merged commit b42f4e0 into main Jul 27, 2026
18 checks passed

avivkeller deleted the remark-lint-changes branch July 27, 2026 02:30

github-actions Bot mentioned this pull request Jul 28, 2026

chore: version packages #9027

Merged

chore(remark-lint): improve for node core by avivkeller · Pull Request #9016 · nodejs/nodejs.org · GitHub

Uh oh!

chore(remark-lint): improve for node core - #9016

chore(remark-lint): improve for node core#9016avivkeller merged 5 commits intomainnodejs/nodejs.org:mainfrom remark-lint-changesnodejs/nodejs.org:remark-lint-changesCopy head branch name to clipboard

Conversation

avivkeller commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

codecov Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Build Size Comparison

Summary

Uh oh!

avivkeller commented Jul 22, 2026

Uh oh!

bmuenzenmeyer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

avivkeller commented Jul 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chore(remark-lint): improve for node core#9016
avivkeller merged 5 commits into
mainfrom
remark-lint-changes

avivkeller commented Jul 21, 2026 •
edited
Loading

vercel Bot commented Jul 21, 2026 •
edited
Loading

cursor Bot commented Jul 21, 2026 •
edited
Loading

codecov Bot commented Jul 21, 2026 •
edited
Loading

github-actions Bot commented Jul 21, 2026 •
edited
Loading