FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(ui): account for nested `code` elements by avivkeller · Pull Request #9028 · nodejs/nodejs.org · GitHub

/ nodejs.org Public

chore(ui): account for nested code elements - #9028

Merged
bmuenzenmeyer merged 2 commits into
mainfrom
fix-ui-hydration
Jul 30, 2026
ConversationCommits (2)ChecksFiles changed
Merged

chore(ui): account for nested code elements#9028
bmuenzenmeyer merged 2 commits into
mainfrom
fix-ui-hydration

Conversation

avivkeller commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

avivkeller requested a review from a team as a code owner July 28, 2026 18:28
Copilot AI review requested due to automatic review settings July 28, 2026 18:28

vercel Bot commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Preview Jul 29, 2026 3:45pm

Copilot AI reviewed Jul 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

cursor Bot commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown

PR Summary

Low Risk
CSS-only selector change in a presentational component with no auth, data, or API impact.

Overview
BaseCodeBox styling no longer assumes code is a direct child of the pre content area. Selectors in index.module.css were relaxed from .content > code to .content code (including the no-line-numbers line rules) so typography, line numbers, and grid layout still apply when doc rendering inserts a wrapper between pre and code—addressing a hydration mismatch noted in doc-kit.

A patch changeset for @node-core/ui-components documents the fix.

Reviewed by Cursor Bugbot for commit 33f10b7. Bugbot is set up for automated code reviews on this repo. Configure here.

avivkeller mentioned this pull request Jul 28, 2026
Merged

codecov Bot commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.09%. Comparing base (c086c54) to head (33f10b7).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9028      +/-   ##
==========================================
- Coverage   75.10%   75.09%   -0.02%     
==========================================
  Files         102      102              
  Lines        9109     9109              
  Branches      372      373       +1     
==========================================
- Hits         6841     6840       -1     
- Misses       2264     2265       +1     
  Partials        4        4

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

cursor Bot reviewed Jul 28, 2026
View reviewed changes

cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a9304fc. Configure here.

Comment thread packages/ui-components/src/Common/BaseCodeBox/index.module.css

github-actions Bot commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total First Load JS 10.65 MB
New Total First Load JS 10.66 MB
Delta 3.73 KB (+0.03%)

Changes

🔄 Modified Routes (4)
Route Old First Load JS New First Load JS Delta
/[locale] 2.54 MB 2.54 MB 📈 954.00 B (+0.04%)
/[locale]/[...path] 2.54 MB 2.54 MB 📈 954.00 B (+0.04%)
/[locale]/blog/[...path] 2.54 MB 2.54 MB 📈 954.00 B (+0.04%)
/[locale]/download/archive/[version] 2.54 MB 2.54 MB 📈 954.00 B (+0.04%)

avivkeller mentioned this pull request Jul 29, 2026
Merged
fixup!
33f10b7 
Signed-off-by: Aviv Keller <me@aviv.sh>
Copilot AI review requested due to automatic review settings July 29, 2026 15:44
Copilot AI reviewed Jul 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

bmuenzenmeyer approved these changes Jul 30, 2026
View reviewed changes

bmuenzenmeyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

it'd be nice to see the before and after of things like this - i know thats hard when we are cross-repo, unpublished, etc... seems reasonable

bmuenzenmeyer added this pull request to the merge queue Jul 30, 2026
Merged via the queue into main with commit ca47d6f Jul 30, 2026
22 checks passed
bmuenzenmeyer deleted the fix-ui-hydration branch July 30, 2026 12:44
bmuenzenmeyer mentioned this pull request Jul 31, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
cursor[bot] cursor[bot] left review comments
bmuenzenmeyer bmuenzenmeyer approved these changes
AugustinMauroy AugustinMauroy approved these changes
bjohansebas bjohansebas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL