test: deflake connect-timeout watchdog - #5197
Merged
metcoder95 merged 3 commits intoJul 3, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #5197 +/- ##
==========================================
- Coverage 93.44% 93.43% -0.02%
==========================================
Files 110 110
Lines 37175 37278 +103
==========================================
+ Hits 34740 34829 +89
- Misses 2435 2449 +14 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
trivikr
reviewed
May 5, 2026
Comment thread
test/connect-timeout.js
trivikr
approved these changes
May 5, 2026
metcoder95
reviewed
May 7, 2026
metcoder95
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
merge conflicts
Sorry, something went wrong.
mcollina
force-pushed
the
fix-5187-connect-timeout-flake
branch
from
be6f49e to
74c219a
Compare
May 19, 2026 07:49
metcoder95
reviewed
May 19, 2026
Comment thread
test/connect-timeout.js
Outdated
metcoder95
approved these changes
Jul 2, 2026
Copy link
Copy Markdown
Member
|
Justs tests are not happy |
Sorry, something went wrong.
Co-authored-by: Carlos Fuentes <me@metcoder.dev>
mcollina
force-pushed
the
fix-5187-connect-timeout-flake
branch
from
58c121f to
acc19a5
Compare
July 2, 2026 17:23
metcoder95
approved these changes
Jul 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Closes #5187