test: add unexpected disconnect guards to http2 tests - #5533
Merged
metcoder95 merged 1 commit intoJul 16, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Add the disconnect guard pattern from docs/best-practices/writing-tests.md to the happy-path HTTP/2 test files so silent reconnects fail the tests. Refs: #251 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mcollina
approved these changes
Jul 11, 2026
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #5533 +/- ##
==========================================
- Coverage 93.44% 93.44% -0.01%
==========================================
Files 110 110
Lines 37329 37329
==========================================
- Hits 34883 34882 -1
- Misses 2446 2447 +1 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
metcoder95
approved these changes
Jul 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the disconnect guard pattern from docs/docs/best-practices/writing-tests.md
to the happy-path HTTP/2 test files, so silent disconnect/reconnect cycles fail
the tests instead of passing unnoticed.
Files covered (12 guards): http2-pseudo-headers.js, http2-continue.js,
http2-connection.js, http2-pipelining-default.js (incl. one Pool guard).
Intentionally skipped: http2-instantiation.js (ALPN-mismatch test where
disconnect is expected) and http2-invalid-connection-headers.js (reconnection
is the behavior under test). Happy to cover http2-body.js and the connect-*
group in follow-ups.
Refs: #251
🤖 Generated with Claude Code