FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

unwrap was missing in type defintion by me23 · Pull Request #158 · nodevault/node-vault · GitHub

unwrap was missing in type defintion - #158

Open
me23 wants to merge 3 commits into
nodevault:masterfrom
me23:master
Open

unwrap was missing in type defintion#158
me23 wants to merge 3 commits into
nodevault:masterfrom
me23:master

Conversation

me23 commented Jun 22, 2020

Copy link
Copy Markdown

No description provided.

codecov Bot commented Jun 22, 2020
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #158   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          146       146           
  Branches        37        37           
=========================================
  Hits           146       146           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 496657b...779a832. Read the comment docs.

Copy link
Copy Markdown
Collaborator

@me23 can you add a test for this?

me23 commented May 11, 2023

Copy link
Copy Markdown
Author

Hi,
there is a test for unwrap already. The only thing i added was the type-definition for the unwrap, so that typescript won't complain about unknown method unwrap... So i don't think we need another test?!
bye
me23

Copy link
Copy Markdown
Collaborator

@me23 there are plenty of changes in your diff, could u please rebase and check that you only pr the relevant change?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL